66182 - [Pref Stylesheet]The "Always use my font settings" checkbox locks face but not size

Status: NEW

(Core :: CSS Parsing and Computation, defect, P5)

Description

[Steve Reid]

The "always use my font settings, overriding web page font" checkbox under
Edit/Preferences/Appearance/Fonts prevents web pages from using different font
faces, but the font sizes may still be changed.

How to reproduce:

1- Under Edit/Preferences/Appearance/Fonts, set your fonts to Times 24 point and
check the "serif" radio button and the "Always use my font settings" checkbox.

2- Visit http://www.mozilla.org/ as a control, to see what that those font
settings are supposed to look like.

3- Visit http://www.arstechnica.com/ to see the "Always use my font settings"
option not doing what it is supposed to. Be prepared to squint.

I'm assuming this affects platform All / OS All as it seems to be part of the
platform-independant parts and has been present for a very long time (I think NS
4 had the same problem with the equivalent option), but for the record I'm
running FreeBSD 4.1-RELEASE on x86 with Mozilla 0.7 compiled from the FreeBSD
ports tree.

Comment 1

[Boris Zbarsky [:bzbarsky]]

This was supposedly fixed in bug 31816, but I am seeing it on the 2001-01-22-06
linux build.  Looks like it was not fixed completely.  Setting status to NEW,
over to style system and assigning to attinasi (who fixed bug 31816).

Comment 2

[Marc Attinasi]

Accepting: yes, there are cases where the specificity of the rules in a webpage
are overriding the font size of the preferences. I'll investigate a possible
solution. Thanks for the report and the link.

Comment 3

[Marc Attinasi]

nsHTMLFontElement needs to be modified further: the method MapFontAttributesInto
needs to ignore an explicit font size if we are not using document fonts.
Currently only the font face is handled correctly in there.

Comment 4

[Bill Nottingham]

This *may* fix it, although having never looked at the code before, it's probably
not very correct. :)

Comment 5

[Bill Nottingham]

Attachment: if we're not using the document fonts, don't look up all the css size/weight/etc. info

Comment 6

[Marc Attinasi]

Probably best to have Hyatt look at this since he is the RuleNode creator. 

Bill, what have you done to test the patch?

Comment 7

[Bill Nottingham]

Enough to discover it's broken, I think. It manages to kill bold & header
attributes, as well as monospace (at least, cnn.com looks *really* odd with this.)

Comment 8

[sairuh (rarely reading bugmail)]

*** Bug 103114 has been marked as a duplicate of this bug. ***

Comment 9

[R.K.Aa.]

was this fixed in bug 105297?

Comment 10

[Bill Nottingham]

AFAIK, no - it still happens in 0.9.8.

Comment 11

[K Chayka]

Still busted in win32 2002020803 trunk build

Font-family does change per prefs, but size is ignored.

Comment 12

[Stuart P.]

Hi, just my $.02, font sizes are completely screwed up on certain pages for me
right out of the starting gate - linux RH7.2, just installed Moz today. Affected
pages are: arstechnica (as noted in another comment), the register
(www.theregus.com). I have not set any custom settings but the fonts are WAY too
small.

Comment 13

[Madhur Bhatia]

cc'ing myself

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Taking those of attinasi's style system bugs that are really style system bugs
and still look valid.

Comment 15

[Jim Kingdon]

This bug is still happening (with the given instructions for reproducing, using
 http://www.arstechnica.com/ as the test case) for me using the Fedora-supplied
build of Firefox 1.0.3 on Fedora Core 3.

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

It's not clear to me whether the right fix here is to change the behavior of the pref or to improve the wording in the UI.  We have a separate set of settings related to font sizes (e.g., minimum font size).  It's not clear to me that changing the behavior of this pref to behave more like the wording makes it sound like it does would actually improve the user experience.  What are the use cases for this preference?