661858 - In High Contrast mode, alert box renders with default presentation

Status: RESOLVED FIXED

(Toolkit :: Themes, defect)

Description

[Damian]

User-Agent:       Mozilla/5.0 (Windows NT 5.1) AppleWebKit/534.24 (KHTML, like Gecko) Chrome/11.0.696.71 Safari/534.24
Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20100101 Firefox/4.0.1

When running windows in High Contrast mode and a javascript alert() is called, the alert box's rendering is the same as if running in normal mode (i.e. not in High Contrast mode).

Reproducible: Always

Steps to Reproduce:
1. Ensure Windows is in High Contrast mode (Left Shift + Left Alt + Print Screen)
2. Enter javascript:alert('Test') into URL field and hit Enter


Actual Results:  
Alert displays with default rendering, not in High Contrast.

Expected Results:  
Alert displays in High Contrast mode.

Comment 1

[Damian]

Attachment: example screenshot

Comment 2

[Justin Dolske [:Dolske]]

The thinking here was that these prompts should appear to be part of the webpage, and not part of chrome, and so matching the OS theme was explicitly not wanted.

But high contrast is an interesting case for A11Y. Maybe we should just use the CSS2 UI colors (eg color: GreyText) or Mozilla extensions (eg color: -moz-dialog).

Comment 3

[alexander :surkov (:asurkov)]

Justin, can we get progress on this please?

Comment 4

[Dão Gottwald [::dao]]

Attachment: patch

Comment 5

[Dão Gottwald [::dao]]

Attachment: patch v2

Also changed the border color to a native one, otherwise the whole box could fade into the dark background.

Comment 6

[Justin Dolske [:Dolske]]

Comment on attachment 630891 [details] [diff] [review]
patch v2

ohai thar old review request. Oops. :(

Comment 7

[Dão Gottwald [::dao]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/a51e6cb95339

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a51e6cb95339