Closed
Bug 661858
Opened 11 years ago
Closed 10 years ago
In High Contrast mode, alert box renders with default presentation
Categories
(Toolkit :: Themes, defect)
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: damian.chojna, Assigned: dao)
References
Details
Attachments
(2 files, 1 obsolete file)
35.63 KB,
image/png
|
Details | |
824 bytes,
patch
|
Dolske
:
review+
|
Details | Diff | Splinter Review |
User-Agent: Mozilla/5.0 (Windows NT 5.1) AppleWebKit/534.24 (KHTML, like Gecko) Chrome/11.0.696.71 Safari/534.24 Build Identifier: Mozilla/5.0 (Windows NT 5.1; rv:2.0.1) Gecko/20100101 Firefox/4.0.1 When running windows in High Contrast mode and a javascript alert() is called, the alert box's rendering is the same as if running in normal mode (i.e. not in High Contrast mode). Reproducible: Always Steps to Reproduce: 1. Ensure Windows is in High Contrast mode (Left Shift + Left Alt + Print Screen) 2. Enter javascript:alert('Test') into URL field and hit Enter Actual Results: Alert displays with default rendering, not in High Contrast. Expected Results: Alert displays in High Contrast mode.
Status: UNCONFIRMED → NEW
Component: General → Themes
Ever confirmed: true
Product: Firefox → Toolkit
QA Contact: general → themes
Comment 2•11 years ago
|
||
The thinking here was that these prompts should appear to be part of the webpage, and not part of chrome, and so matching the OS theme was explicitly not wanted. But high contrast is an interesting case for A11Y. Maybe we should just use the CSS2 UI colors (eg color: GreyText) or Mozilla extensions (eg color: -moz-dialog).
Comment 3•10 years ago
|
||
Justin, can we get progress on this please?
Assignee | ||
Comment 4•10 years ago
|
||
Assignee | ||
Comment 5•10 years ago
|
||
Also changed the border color to a native one, otherwise the whole box could fade into the dark background.
Attachment #630890 -
Attachment is obsolete: true
Attachment #630890 -
Flags: review?(dolske)
Attachment #630891 -
Flags: review?(dolske)
Comment 6•10 years ago
|
||
Comment on attachment 630891 [details] [diff] [review] patch v2 ohai thar old review request. Oops. :(
Attachment #630891 -
Flags: review?(dolske) → review+
Assignee | ||
Comment 7•10 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/a51e6cb95339
Comment 8•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/a51e6cb95339
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in
before you can comment on or make changes to this bug.
Description
•