661987 - Failed loadVirtualFolders causes tab registration to fail (so addons won't load)

Status: RESOLVED FIXED

(MailNews Core :: Account Manager, defect)

Description

[Kent James (:rkent)]

(This is a New Account Types issue)

If I remove an addon that contains necessary registration information for virtual folders, and then remove that addon, then I get a failure in msqMail3PaneWindow.js ath:

accountManager.loadVirtualFolders();

This error cascades to callers, eventually causing openSpecialTabsOnStartup() to fail, so that contentTabs do not get registered. And without contentTabs, the addon manager won't load, so you can't fix the root cause with the addon.

Comment 1

[Kent James (:rkent)]

Attachment: Both check in js, and stop error in C++

This gets contentTabs registered even if virtual folder loading fails.

Comment 2

[Kent James (:rkent)]

Attachment: virtual folder file to cause bug

STR: In a test profile, replace the virtualFolders.dat file with this file, which tries to load a virtual folder as the subfolder of a non-existent protocol type dummy:

Comment 3

[Kent James (:rkent)]

Attachment: Don't report error

In the former patch, if there is only a single virtual folder, which is invalid, then an error shows in the error console. No need for that, since these virtual folders are appearing on presumably non-existent servers.

I think I would like to land this. It is low risk, and the consequences are quite devastating.

Comment 4

[Kent James (:rkent)]

Comment on attachment 548848 [details] [diff] [review]
Don't report error

Checked in http://hg.mozilla.org/comm-central/rev/a5788969f194