661998 - Intermittent test_auth_proxy.js command timed out: 1200 seconds without output, attempting to kill

Status: RESOLVED FIXED

(Core :: Networking, defect)

Description

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307137450.1307139447.4584.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central opt test xpcshell on 2011/06/03 14:44:10
s: talos-r3-leopard-053

TEST-INFO | /Users/cltbld/talos-slave/test/build/xpcshell/tests/netwerk/test/unit/test_auth_proxy.js | running test ...

command timed out: 1200 seconds without output, attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=1590.522201

Comment 1

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307304015.1307305855.4398.gz

Comment 2

[Phil Ringnalda (:philor)]

Attachment: probable fix

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 537478 [details] [diff] [review]
probable fix

It looks like it's still possible for the timers to step over each other (e.g. if runLater is called multiple times in succession, followed by a GC before the initial timer fires). Probably less likely to be problematic than the current setup, but this would be more robust if it was converted to use executeSoon.

Comment 4

[(no longer active)]

Comment on attachment 537478 [details] [diff] [review]
probable fix

Gavin is right.  But AFAIK, we don't have executeSoon available in xpcshell based tests.  A simple workaround would be to use a global array to hold the timers, and instead of assigning to |timer|, appending the timers to that array.

Comment 5

[Josh Matthews [:jdm]]

xpcshell has do_execute_soon.

Comment 6

[(no longer active)]

(In reply to comment #5)
> xpcshell has do_execute_soon.

Josh, was that an indication that you volunteered to take this?  :)

Comment 7

[Josh Matthews [:jdm]]

Might as well make it official.

Comment 8

[:Gavin Sharp [email: [e-mail]]]

even if that helper didn't exist, implementing executeSoon really isn't difficult :)

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

WinOpt:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307426263.1307429669.3720.gz

> TEST-INFO | c:\talos-slave\test\build\xpcshell\tests\netwerk\test\unit\test_auth_proxy.js | running test ...
> 
> command timed out: 1200 seconds without output, killing pid 1252
> program finished with exit code 1
> elapsedTime=2919.380000

Comment 10

[Josh Matthews [:jdm]]

Attachment: Fix risky use of nsITimer in xpcshell test.

Comment 11

[(no longer active)]

Pushed to cedar.

Comment 12

[Phil Ringnalda (:philor)]

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1307518263.1307521695.23005.gz

Comment 13

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/ef7b40f47503