Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Intermittent test_auth_proxy.js command timed out: 1200 seconds without output, attempting to kill

RESOLVED FIXED in mozilla7

Status

()

Core
Networking
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: philor, Assigned: jdm)

Tracking

({intermittent-failure})

Trunk
mozilla7
x86
Mac OS X
intermittent-failure
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307137450.1307139447.4584.gz
Rev3 MacOSX Leopard 10.5.8 mozilla-central opt test xpcshell on 2011/06/03 14:44:10
s: talos-r3-leopard-053

TEST-INFO | /Users/cltbld/talos-slave/test/build/xpcshell/tests/netwerk/test/unit/test_auth_proxy.js | running test ...

command timed out: 1200 seconds without output, attempting to kill
process killed by signal 9
program finished with exit code -1
elapsedTime=1590.522201
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307304015.1307305855.4398.gz
Created attachment 537478 [details] [diff] [review]
probable fix
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #537478 - Flags: review?(ehsan)
Blocks: 640629
Comment on attachment 537478 [details] [diff] [review]
probable fix

It looks like it's still possible for the timers to step over each other (e.g. if runLater is called multiple times in succession, followed by a GC before the initial timer fires). Probably less likely to be problematic than the current setup, but this would be more robust if it was converted to use executeSoon.
Comment on attachment 537478 [details] [diff] [review]
probable fix

Gavin is right.  But AFAIK, we don't have executeSoon available in xpcshell based tests.  A simple workaround would be to use a global array to hold the timers, and instead of assigning to |timer|, appending the timers to that array.
Attachment #537478 - Flags: review?(ehsan) → review-
Assignee: philringnalda → nobody
(Assignee)

Comment 5

6 years ago
xpcshell has do_execute_soon.
(In reply to comment #5)
> xpcshell has do_execute_soon.

Josh, was that an indication that you volunteered to take this?  :)
(Assignee)

Comment 7

6 years ago
Might as well make it official.
Assignee: nobody → josh
even if that helper didn't exist, implementing executeSoon really isn't difficult :)
WinOpt:
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307426263.1307429669.3720.gz

> TEST-INFO | c:\talos-slave\test\build\xpcshell\tests\netwerk\test\unit\test_auth_proxy.js | running test ...
> 
> command timed out: 1200 seconds without output, killing pid 1252
> program finished with exit code 1
> elapsedTime=2919.380000
(Assignee)

Comment 10

6 years ago
Created attachment 537754 [details] [diff] [review]
Fix risky use of nsITimer in xpcshell test.
Attachment #537754 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
Pushed to cedar.
Keywords: checkin-needed
Whiteboard: [orange] → [orange][fixed-in-cedar]
http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1307518263.1307521695.23005.gz
http://hg.mozilla.org/mozilla-central/rev/ef7b40f47503
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [orange][fixed-in-cedar] → [orange]
Target Milestone: --- → mozilla7
Keywords: intermittent-failure
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.