662000 - Remove XPC_IDISPATCH_SUPPORT

Status: RESOLVED FIXED

(Core :: XPConnect, defect)

Description

[Matheus Kerschbaum]

User-Agent:       Mozilla/5.0 (Windows NT 6.1; rv:7.0a1) Gecko/20110603 Firefox/7.0a1
Build Identifier: 

Obsolete API that only serves to support the soon to be removed ActiveX embedding API.

Reproducible: Always

Comment 1

[Matheus Kerschbaum]

Attachment: part 1: Remove interfaces and tests

Comment 2

[Matheus Kerschbaum]

Attachment: part 2: Remove XPC_IDISPATCH_SUPPORT from the build-system and XPConnect

Comment 3

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 537294 [details] [diff] [review]
part 2: Remove XPC_IDISPATCH_SUPPORT from the build-system and XPConnect

Review of attachment 537294 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/xpconnect/src/xpcinlines.h
@@ +270,5 @@
>  
>  inline JSBool
>  XPCCallContext::HasInterfaceAndMember() const
>  {
> +    return mState >= HAVE_NAME && mInterface && (mMember);

Nitpick: no need for the parens around mMember here.

::: js/src/xpconnect/src/xpcthrower.cpp
@@ +183,2 @@
>          {
>              id = ccx.GetMember()->GetName();

This can become |jsid id = ccx.GetMember()->GetName();| now.

::: js/src/xpconnect/src/xpcwrappednative.cpp
@@ +360,1 @@
>          identity = helper.GetCanonical();

Combine these two lines into one.

@@ +825,1 @@
>              identity = do_QueryInterface(Object);

Ditto.

Comment 4

[Matheus Kerschbaum]

Attachment: part 2: Remove XPC_IDISPATCH_SUPPORT from the build-system and XPConnect

Updated per review comments.

Comment 5

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/d115405d4e0b
http://hg.mozilla.org/mozilla-central/rev/65936325f47f

Comment 6

[(no longer active)]

The push broke the build, so I backed out all of its changesets (although I highly suspect that this bug was the culprit).

Comment 7

[Ed Morley [:emorley]]

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1308024044.1308025082.27561.gz#err0

/builds/slave/cen-osx64/build/js/src/xpconnect/src/xpcthrower.cpp:183: warning: unused variable 'id'
/builds/slave/cen-osx64/build/js/src/xpconnect/src/xpcthrower.cpp:186: error: 'id' was not declared in this scope

In this hunk:
https://bugzilla.mozilla.org/attachment.cgi?id=539001&action=diff#a/js/src/xpconnect/src/xpcthrower.cpp_sec1

Caused by the braces around:
| jsid id = ccx.GetMember()->GetName(); |


Anyway, good riddance to ActiveX! :-)

Comment 8

[Matheus Kerschbaum]

Attachment: part 2: Remove XPC_IDISPATCH_SUPPORT from the build-system and XPConnect

Thanks for noticing my mistake Ed, and sorry for breaking the tree!

I pushed this updated patch to try (http://tbpl.mozilla.org/?tree=Try&rev=0c4e143610a7) to make sure everything is ok, but the build is failing with some really bizarre errors (http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-0c4e143610a7/try-linux64/try-linux64-build525.txt.gz).

Am I doing something stupid or is the buildbot just screwing with me?

Comment 9

[Matheus Kerschbaum]

Try was ok with this when I pushed again, so setting checkin-needed.

Comment 10

[Matheus Kerschbaum]

Attachment: part 2: Remove XPC_IDISPATCH_SUPPORT from the build-system and XPConnect

Updated to tip.

Comment 11

[(no longer active)]

Landed on inbound.

Comment 12

[Mounir Lamouri (:mounir)]

Pushed:
http://hg.mozilla.org/mozilla-central/rev/64ff58414b5a
http://hg.mozilla.org/mozilla-central/rev/b0507816cb5e