jsval.h:466:5: warning: C++ style comments are not allowed in ISO C90

RESOLVED FIXED in mozilla7

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning][fixed-in-tracemonkey])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 537380 [details] [diff] [review]
trivial fix. (use /**/ comments instead)

This changeset:
  http://hg.mozilla.org/mozilla-central/rev/14b1ffc1bf53
added some C++ style "//" comments to jsval.h, which gets included by .c files, and triggers this GCC warning:
> jsval.h:466:5: warning: C++ style comments are not allowed in ISO C90

Fix attached.
Attachment #537380 - Flags: review?(mrbkap)
Comment on attachment 537380 [details] [diff] [review]
trivial fix. (use /**/ comments instead)

Can you reword the comment so it fits on one line? If not, the style in the JS engine for multi-line comments is:

/*
 * Comment here...
 */
Attachment #537380 - Flags: review?(mrbkap) → review+
(Assignee)

Comment 2

6 years ago
Converted to correct multi-line style & landed:
http://hg.mozilla.org/tracemonkey/rev/49cfb12c2225
Whiteboard: [build_warning] → [build_warning][fixed-in-tracemonkey]
Target Milestone: --- → mozilla7
cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/49cfb12c2225
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.