662114 - MSVC warning C4251: 'js::ForceFrame::frame' : class 'js::DummyFrameGuard' needs to have dll-interface to be used by clients of class 'js::ForceFrame'

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Phil Ringnalda (:philor)]

I don't know what a word of it means, but I do know the constant red from the new Windows warnings-as-errors builds burns my eyes.

http://tinderbox.mozilla.org/showlog.cgi?log=TraceMonkey/1307150137.1307150235.18665.gz

e:\builds\moz2_slave\tm-w32-spidermonkey-warnaserr\src\js\src\jswrapper.h(167) : error C2220: warning treated as error - no 'object' file generated

e:\builds\moz2_slave\tm-w32-spidermonkey-warnaserr\src\js\src\jswrapper.h(167) : warning C4251: 'js::ForceFrame::frame' : class 'js::DummyFrameGuard' needs to have dll-interface to be used by clients of class 'js::ForceFrame'

        e:\builds\moz2_slave\tm-w32-spidermonkey-warnaserr\src\js\src\vm/Stack.h(1373) : see declaration of 'js::DummyFrameGuard'

make[1]: Leaving directory `/e/builds/moz2_slave/tm-w32-spidermonkey-warnaserr/objdir/js'

Comment 1

[Phil Ringnalda (:philor)]

And beyond just my whining, someone yesterday thought he shouldn't push to TM, because it had unstarred red.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

So, I just filed this earlier today. I guess it's not a TI-specific warning then. Bug 662083. Dupe whichever way you want.

Comment 3

[Phil Ringnalda (:philor)]

I say we race the two bugs, see who has a faster cc list :)

Comment 4

[David Mandelin [:dmandelin]]

Blake, did you add the DummyFrameGuard? I ask because the fix is nontrivial. I think we can't just add a JS_FRIEND_API there--that generates other warnings, so they might spread all over the place. Hopefully there is some smaller fix.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

This is unfortunate. It appears that if you use a non-friend-API from a friend-API class, then you get a warning under Windows. This also applies to the Maybe<> class, so there isn't an obvious way to use it here, either.

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Proposed fix

Oops.

Comment 8

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/tracemonkey/rev/561b7ff79523

Comment 9

[Chris Leary [:cdleary] (not checking bugmail)]

cdleary-bot mozilla-central merge info:
http://hg.mozilla.org/mozilla-central/rev/561b7ff79523