662185 - "ASSERTION: Charset name equality check failed"

Status: RESOLVED WORKSFORME

(Core :: DOM: HTML Parser, defect)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: Charset name equality check failed.: 'Not Reached', file parser/html/nsHtml5StreamParser.cpp, line 902

nsHtml5StreamParser::internalEncodingDeclaration [parser/html/nsHtml5StreamParser.cpp:903]
nsHtml5Tokenizer::internalEncodingDeclaration [parser/html/nsHtml5Tokenizer.cpp:3692]
nsHtml5TreeBuilder::checkMetaCharset [parser/html/nsHtml5TreeBuilder.cpp:1999]
nsHtml5TreeBuilder::startTag [parser/html/nsHtml5TreeBuilder.cpp:1381]
nsHtml5Tokenizer::emitCurrentTagToken [parser/html/nsHtml5Tokenizer.cpp:308]
nsHtml5Tokenizer::stateLoop [parser/html/nsHtml5Tokenizer.cpp:863]
nsHtml5Tokenizer::tokenizeBuffer [parser/html/nsHtml5Tokenizer.cpp:391]
nsHtml5StreamParser::ParseAvailableData [parser/html/nsHtml5StreamParser.cpp:1008]
nsHtml5StreamParser::DoStopRequest [parser/html/nsHtml5StreamParser.cpp:743]
nsHtml5RequestStopper::Run [parser/html/nsHtml5StreamParser.cpp:757]
nsThread::ProcessNextEvent [xpcom/threads/nsThread.cpp:618]
NS_ProcessNextEvent_P [obj-firefox/xpcom/build/nsThreadUtils.cpp:245]
nsThread::ThreadFunc [xpcom/threads/nsThread.cpp:272]
_pt_root [nsprpub/pr/src/pthreads/ptthread.c:190]
libSystem.B.dylib + 0x3a4f6

Comment 1

[Boris Zbarsky [:bzbarsky]]

Equals() for charsets will fail if either charset is unknown (i.e. if GetPreferred fails).

So I think this assertion is just bogus.

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

I've been hitting this a fair amount recently on German ad networks.  If the assert is bogus can we just remove it?

Comment 3

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

No longer reproducible on trunk.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0b431dca21e8
Add crashtest.

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/0b431dca21e8