66227 - Manually selected charset is not marked on the charset menu.

Status: VERIFIED FIXED

(MailNews Core :: Internationalization, defect)

Description

[ji]

***Observed with 20001-01-19-06-mtrunk build******
When you have a mail with wrong charset info in the body, after you manually
select the right charset to be able to read the mail, the right charset is not
marked on the View | Character Encoding menu.

Steps to reproduce:
1. Have a mail with incorrectly labeled body in the mail box.
2. Select the right charset to be able to read the mail.
3. Select View | Character Encoding, you'll see the right charset you just
manually selected is not marked on the left.

Comment 1

[ji]

Attachment: ISO-2022-JP message incorrectly labeled as ISO-8859-1

Comment 2

[marina]

isn't it related to bug# 61285?

Comment 3

[nhottanscp]

It may be a dup, bug 61285 is for non MIME label case, this bug is about override.
I keep them as separate for now.

Comment 4

[nhottanscp]

Attachment: Patch, set msgWindow charset when the user does override using charset menu

Comment 5

[nhottanscp]

I found there are some cases which charset is not set to msgWindow in libmime.
That causes the problem of check mark not marked correctly.
When the user overrides using the menu, we can make sure the user selected
charset is set to msgWindow instead of relying on libmime to mark it.
Scott, could you review the patch?

Comment 6

[Scott MacGregor]

naoki, your code change looks great. sr=mscott
However, I didn't know what you were doing with the new xul and js files you
added to manifest and makefile.win. Those aren't part of this fix right? 

Also, you no longer need to add chrome files to manifest and makefiles. Just add
them to the appropriate jar.mn file and you should be in business. We still need
to clean up the mailnews makefiles and remove the chrome entries which aren't
used anymore.

Comment 7

[nhottanscp]

Right, the makefile is there for a mistake (not related to this bug). As you
mentioned, they are not needed so I did not check them in for the other bug. I
should revert the local change to avoid confusion.

Comment 8

[nhottanscp]

Attachment: New patch, removed unrelated changes from the previous diff.

Comment 9

[David :Bienvenu]

sr=bienvenu

Comment 10

[nhottanscp]

checked in

Comment 11

[ji]

Verified with 2001-02-08 win32, linux and Mac trunk builds. It is fixed.