Closed Bug 662288 Opened 9 years ago Closed 9 years ago

Implement CSS3 unicode-bidi: plaintext

Categories

(Core :: Layout: Text and Fonts, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla10

People

(Reporter: smontagu, Assigned: smontagu)

References

()

Details

(Keywords: dev-doc-complete, rtl)

Attachments

(1 file, 1 obsolete file)

See also bug 613149
Depends on: 613149
+1 to the priority of this, I would love to see this implemented so that we can have 613149 fixed
Attached patch Patch (obsolete) — Splinter Review
Assignee: nobody → smontagu
Status: NEW → ASSIGNED
Attachment #556835 - Flags: review?(roc)
Target Milestone: mozilla7 → mozilla9
Comment on attachment 556835 [details] [diff] [review]
Patch

Review of attachment 556835 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsBlockFrame.cpp
@@ +3567,5 @@
> +  // frame, because the block frame could be split by hard line breaks into
> +  // multiple paragraphs with different base direction
> +  FramePropertyTable *propTable = aState.mPresContext->PropertyTable();
> +  PRUint8 direction = PRUint32(propTable->Get(aLine->mFirstChild,
> +                                              BaseLevelProperty())) & 1;

Can we store this direction in a state bit so we don't have to do a mildly-expensive property get here?

Or condition this on bidi being enabled?
Attached patch Patch v.2Splinter Review
Howzabouts if we move the test on unicode-bidi: plaintext out of BeginLineReflow to the callers, like so?
Attachment #556835 - Attachment is obsolete: true
Attachment #556835 - Flags: review?(roc)
Attachment #557016 - Flags: review?(roc)
https://hg.mozilla.org/integration/mozilla-inbound/rev/388df914497e
Flags: in-testsuite?
Target Milestone: mozilla9 → mozilla10
Flags: in-testsuite? → in-testsuite+
Keywords: dev-doc-needed
https://hg.mozilla.org/mozilla-central/rev/388df914497e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Keywords: rtl
You need to log in before you can comment on or make changes to this bug.