The default bug view has changed. See this FAQ.

Implement CSS3 unicode-bidi: plaintext

RESOLVED FIXED in mozilla10

Status

()

Core
Layout: Text
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: smontagu, Assigned: smontagu)

Tracking

({dev-doc-complete, rtl})

unspecified
mozilla10
dev-doc-complete, rtl
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
See also bug 613149
(Assignee)

Updated

6 years ago
Depends on: 613149

Comment 1

6 years ago
+1 to the priority of this, I would love to see this implemented so that we can have 613149 fixed
(Assignee)

Comment 2

6 years ago
Created attachment 556835 [details] [diff] [review]
Patch
Assignee: nobody → smontagu
Status: NEW → ASSIGNED
Attachment #556835 - Flags: review?(roc)
(Assignee)

Updated

6 years ago
Target Milestone: mozilla7 → mozilla9
Comment on attachment 556835 [details] [diff] [review]
Patch

Review of attachment 556835 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/generic/nsBlockFrame.cpp
@@ +3567,5 @@
> +  // frame, because the block frame could be split by hard line breaks into
> +  // multiple paragraphs with different base direction
> +  FramePropertyTable *propTable = aState.mPresContext->PropertyTable();
> +  PRUint8 direction = PRUint32(propTable->Get(aLine->mFirstChild,
> +                                              BaseLevelProperty())) & 1;

Can we store this direction in a state bit so we don't have to do a mildly-expensive property get here?

Or condition this on bidi being enabled?
(Assignee)

Comment 4

6 years ago
Created attachment 557016 [details] [diff] [review]
Patch v.2

Howzabouts if we move the test on unicode-bidi: plaintext out of BeginLineReflow to the callers, like so?
Attachment #556835 - Attachment is obsolete: true
Attachment #556835 - Flags: review?(roc)
Attachment #557016 - Flags: review?(roc)
Attachment #557016 - Flags: review?(roc) → review+
(Assignee)

Comment 5

6 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/388df914497e
Flags: in-testsuite?
Target Milestone: mozilla9 → mozilla10
(Assignee)

Updated

6 years ago
Flags: in-testsuite? → in-testsuite+

Updated

6 years ago
Keywords: dev-doc-needed
https://hg.mozilla.org/mozilla-central/rev/388df914497e
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
I've updated:
https://developer.mozilla.org/en/CSS/unicode-bidi
https://developer.mozilla.org/en/Firefox_10_for_developers
Keywords: dev-doc-needed → dev-doc-complete
(Assignee)

Updated

5 years ago
Keywords: rtl
You need to log in before you can comment on or make changes to this bug.