Closed
Bug 662358
Opened 15 years ago
Closed 14 years ago
Implement mingw variant of nsXPTCStubBase::StubXX directly in assembly
Categories
(Core :: XPConnect, defect)
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: jacek, Assigned: jacek)
Details
(Whiteboard: [inbound])
Attachments
(1 file)
|
3.39 KB,
patch
|
benjamin
:
review+
|
Details | Diff | Splinter Review |
GCC doesn't support __declspec(naked) for x86, so the current code depends on how GCC decides to compile it. It worked good so far, but since GCC 4.6.0 it causes crashes on optimized builds. I've rewritten it directly in assembly, just like other GCC targets do.
Attachment #537616 -
Flags: review?
|
Assignee | |
Updated•15 years ago
|
Attachment #537616 -
Flags: review? → review?(timeless)
|
|
Assignee | |
Comment 1•14 years ago
|
||
timeless, ping
|
|
Assignee | |
Updated•14 years ago
|
Attachment #537616 -
Flags: review?(timeless) → review?(benjamin)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 537616 [details] [diff] [review]
fix v1.0
As mingw-only I'll rubberstamp this: I haven't actually reviewed it but I don't think it's necessary for port-specific code.
Attachment #537616 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Thanks, pushed to m-i:
https://hg.mozilla.org/integration/mozilla-inbound/rev/10e47df463b9
Whiteboard: [inbound]
|
||
Comment 4•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•