Implement mingw variant of nsXPTCStubBase::StubXX directly in assembly

RESOLVED FIXED in mozilla10

Status

()

Core
XPConnect
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla10
x86
Windows 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [inbound])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 537616 [details] [diff] [review]
fix v1.0

GCC doesn't support __declspec(naked) for x86, so the current code depends on how GCC decides to compile it. It worked good so far, but since GCC 4.6.0 it causes crashes on optimized builds. I've rewritten it directly in assembly, just like other GCC targets do.
Attachment #537616 - Flags: review?
(Assignee)

Updated

6 years ago
Attachment #537616 - Flags: review? → review?(timeless)
(Assignee)

Comment 1

6 years ago
timeless, ping
(Assignee)

Updated

6 years ago
Attachment #537616 - Flags: review?(timeless) → review?(benjamin)
Comment on attachment 537616 [details] [diff] [review]
fix v1.0

As mingw-only I'll rubberstamp this: I haven't actually reviewed it but I don't think it's necessary for port-specific code.
Attachment #537616 - Flags: review?(benjamin) → review+
(Assignee)

Comment 3

6 years ago
Thanks, pushed to m-i:

https://hg.mozilla.org/integration/mozilla-inbound/rev/10e47df463b9
Whiteboard: [inbound]

Comment 4

6 years ago
https://hg.mozilla.org/mozilla-central/rev/10e47df463b9
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.