Closed Bug 662390 Opened 9 years ago Closed 9 years ago

Define a preprocessor var for e10s compatibilty

Categories

(Firefox Build System :: General, defect)

x86
All
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla8

People

(Reporter: Felipe, Assigned: Felipe)

References

Details

(Whiteboard: [e10s])

Attachments

(1 file)

Attached patch PatchSplinter Review
Temporary preprocessor variable to be used to switch code and produce a e10s compatible build.

I think I found a middle-ground with the naming for the negative logic.. example usage would be:

#ifdef E10S_COMPAT
 // XXX todo AeroPeek throws on startup, bug NNNNNN 
#else
  if (Win7Features)
    Win7Features.onOpenWindow();
#endif

Ultimately some of these conditions will become runtime checks, and some others will just disappear.. this var will be removed at some point
Attachment #537646 - Flags: review?(khuey)
Attachment #537646 - Flags: review?(khuey) → review+
Just to clarify, this is a transition step to get Firefox-on-e10s working? You'll be building with --enable-e10s-compat, which will disable bits of code that don't currently work, until you get everything working, at which point you'll remove this option and the ifdefs?

If that's correct, can you file a follow-up bug to track the removal? (presumably it can depend on the Firefox e10s tracking bug) Also, mention that bug number in a comment above the option in configure.in.
That's precisely it, Ted. Filed bug 662601 and mentioned it in the comment

Landed in e10s:
http://hg.mozilla.org/projects/electrolysis/rev/c68fab138909
Whiteboard: [e10s] → [e10s][landed in e10s]
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 663042
I backed out everything from central since Android and Maemo were unhappy about the push these changes were part of.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
http://hg.mozilla.org/mozilla-central/rev/20fb4a801fee
Status: REOPENED → RESOLVED
Closed: 9 years ago9 years ago
Resolution: --- → FIXED
Whiteboard: [e10s][landed in e10s] → [e10s]
Target Milestone: --- → mozilla8
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.