662390 - Define a preprocessor var for e10s compatibilty

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

Temporary preprocessor variable to be used to switch code and produce a e10s compatible build.

I think I found a middle-ground with the naming for the negative logic.. example usage would be:

#ifdef E10S_COMPAT
 // XXX todo AeroPeek throws on startup, bug NNNNNN 
#else
  if (Win7Features)
    Win7Features.onOpenWindow();
#endif

Ultimately some of these conditions will become runtime checks, and some others will just disappear.. this var will be removed at some point

Comment 1

[(not currently active) Ted Mielczarek]

Just to clarify, this is a transition step to get Firefox-on-e10s working? You'll be building with --enable-e10s-compat, which will disable bits of code that don't currently work, until you get everything working, at which point you'll remove this option and the ifdefs?

If that's correct, can you file a follow-up bug to track the removal? (presumably it can depend on the Firefox e10s tracking bug) Also, mention that bug number in a comment above the option in configure.in.

Comment 2

[:Felipe Gomes (needinfo for replies!)]

That's precisely it, Ted. Filed bug 662601 and mentioned it in the comment

Landed in e10s:
http://hg.mozilla.org/projects/electrolysis/rev/c68fab138909

Comment 3

[Marco Bonardo [:mak]]

I backed out everything from central since Android and Maemo were unhappy about the push these changes were part of.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

http://hg.mozilla.org/mozilla-central/rev/20fb4a801fee