The default bug view has changed. See this FAQ.

Define a preprocessor var for e10s compatibilty

RESOLVED FIXED in mozilla8

Status

()

Core
Build Config
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Felipe, Assigned: Felipe)

Tracking

Trunk
mozilla8
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [e10s])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 537646 [details] [diff] [review]
Patch

Temporary preprocessor variable to be used to switch code and produce a e10s compatible build.

I think I found a middle-ground with the naming for the negative logic.. example usage would be:

#ifdef E10S_COMPAT
 // XXX todo AeroPeek throws on startup, bug NNNNNN 
#else
  if (Win7Features)
    Win7Features.onOpenWindow();
#endif

Ultimately some of these conditions will become runtime checks, and some others will just disappear.. this var will be removed at some point
Attachment #537646 - Flags: review?(khuey)
Attachment #537646 - Flags: review?(khuey) → review+
Just to clarify, this is a transition step to get Firefox-on-e10s working? You'll be building with --enable-e10s-compat, which will disable bits of code that don't currently work, until you get everything working, at which point you'll remove this option and the ifdefs?

If that's correct, can you file a follow-up bug to track the removal? (presumably it can depend on the Firefox e10s tracking bug) Also, mention that bug number in a comment above the option in configure.in.
(Assignee)

Comment 2

6 years ago
That's precisely it, Ted. Filed bug 662601 and mentioned it in the comment

Landed in e10s:
http://hg.mozilla.org/projects/electrolysis/rev/c68fab138909
Whiteboard: [e10s] → [e10s][landed in e10s]
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Blocks: 663042
I backed out everything from central since Android and Maemo were unhappy about the push these changes were part of.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/mozilla-central/rev/20fb4a801fee
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
Whiteboard: [e10s][landed in e10s] → [e10s]
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.