Avoid overwarning on undefined property accesses in strict mode

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: bhackett, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
The JM branch includes the patch for bug 647626, which fixed a bug where we weren't warning on undefined property accesses in strict mode for GET{LOCAL,ARG,THIS}PROP opcodes.  This is now causing a gigantic warning flood and resulting orange on mochitest-other due to what looks like several different hot sites accessing undefined object properties.  I don't know if this will fix the orange outright, but it seems good to avoid this spam and report about such undefined accesses either once per script or once per access site.  Leaning towards the former, which is much simpler to implement (there is also already some precedent here, script->warnedAboutTwoArgumentEval).
(Reporter)

Comment 1

6 years ago
http://hg.mozilla.org/projects/jaegermonkey/rev/58be28e45a26
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.