662520 - NewTab popup indicator 'arrow' is missing or is pointed to the right instead of left

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P3)

Description

[Cristian Nicolae (:xti)]

Attachment: screenshot

Build id : Mozilla/5.0 (Android;Linux armv7l;rv:7.0a1)Gecko/20110607
Firefox/7.0a1 Fennec/7.0a1
Device: Motorola Droid 2
OS: Android 2.2

Steps to reproduce:
1. Open Nightly app
2. Go to http://popuptest.com/popuptest1.html
3. Tap on Always Show button from the Notification Bar
4. Reload the page opened at step 2

Expected result:
A popup toaster is displayed on the middle-left edge of the screen. Its arrow is pointed to the left.

Actual result:
The toaster arrow is missing or it's pointed to the right.

Note:
Please see the following video: http://www.youtube.com/user/qaioana#p/a/u/0/IjWBASqaec0

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

The 'newtab' popup is not a toaster, so I edited the title.

it seems like the arrowbox is being positioned slightly offscreen, which is causing the arrow calculation to mess up positioning the arrow.

Comment 2

[Aaron Train [:aaronmt]]

This works fine for me as expected (in Portrait view) using the same build on the N1. Landscape view I see the described behaviour.

Comment 3

[Lucas Rocha (:lucasr)]

Attachment: Force arrow to point to tabs container by introducing new methods to arrowbox

The problem here is that when the new tab overflows the tab scrollbox, the calculation of the arrow direction gets confused because it uses getBoundingClientRect() on the anchorNode which doesn't discard the overflown area of the tab.

I introduce two new methods to arrowbox: pointLeftTo() and pointRightTo() which will simply force the arrow direction and set the position according to a certain node. Those methods don't anchor the arrow to the target node as we're forcing direction (anchoring would be pointless). A code refactoring to allow anchorTo, pointLeftTo, and pointRightTo to share same code was necessary.

Comment 4

[Lucas Rocha (:lucasr)]

Attachment: Updated patch with hg user info and commit message

Also fixes a type and renames method to pointLeftAt and pointRightAt which makes more sense English-wise.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/f1a3fea305ff

Comment 6

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/f1a3fea305ff

Comment 7

[Aaron Train [:aaronmt]]

Verified Fixed
Mozilla/5.0 (Android; Linux armv7l; rv:8.0a1) Gecko/20110810 Firefox/8.0a1 Fennec/8.0a1