Closed
Bug 662534
Opened 14 years ago
Closed 14 years ago
Let imgRequestProxy implement nsITimedChannel, collect telemetry
Categories
(Core :: Networking, enhancement)
Core
Networking
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: mayhemer, Assigned: mayhemer)
References
Details
Attachments
(1 file)
|
6.64 KB,
patch
|
joe
:
review+
|
Details | Diff | Splinter Review |
In bug 658894 we collect some basic telemetry for a page load and its subrequests. However, image requests are not included because imgRequetsProxy doesn't implement the new nsITimedChannel interface.
I have a patch for that already, will submit that for review after it passes try.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #538239 -
Flags: review?(joe)
|
|
||
Comment 2•14 years ago
|
||
Comment on attachment 538239 [details] [diff] [review]
v1
Review of attachment 538239 [details] [diff] [review]:
-----------------------------------------------------------------
::: modules/libpr0n/src/imgRequestProxy.h
@@ +82,5 @@
> NS_DECL_IMGIREQUEST
> NS_DECL_NSIREQUEST
> NS_DECL_NSISUPPORTSPRIORITY
> NS_DECL_NSISECURITYINFOPROVIDER
> + // nsITimedChannel declared bellow
"below"
Attachment #538239 -
Flags: review?(joe) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
Whiteboard: [inbound]
|
||
Updated•14 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
|
|
||
Comment 4•14 years ago
|
||
You need to log in
before you can comment on or make changes to this bug.
Description
•