The default bug view has changed. See this FAQ.

Let imgRequestProxy implement nsITimedChannel, collect telemetry

RESOLVED FIXED in mozilla7

Status

()

Core
Networking
--
enhancement
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mayhemer, Assigned: mayhemer)

Tracking

Trunk
mozilla7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

v1
6.64 KB, patch
Joe Drew (not getting mail)
: review+
Details | Diff | Splinter Review
(Assignee)

Description

6 years ago
In bug 658894 we collect some basic telemetry for a page load and its subrequests.  However, image requests are not included because imgRequetsProxy doesn't implement the new nsITimedChannel interface.

I have a patch for that already, will submit that for review after it passes try.
(Assignee)

Comment 1

6 years ago
Created attachment 538239 [details] [diff] [review]
v1
Attachment #538239 - Flags: review?(joe)
Comment on attachment 538239 [details] [diff] [review]
v1

Review of attachment 538239 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/libpr0n/src/imgRequestProxy.h
@@ +82,5 @@
>    NS_DECL_IMGIREQUEST
>    NS_DECL_NSIREQUEST
>    NS_DECL_NSISUPPORTSPRIORITY
>    NS_DECL_NSISECURITYINFOPROVIDER
> +  // nsITimedChannel declared bellow

"below"
Attachment #538239 - Flags: review?(joe) → review+
(Assignee)

Comment 3

6 years ago
Landed as http://hg.mozilla.org/integration/mozilla-inbound/rev/c023a6a059d1
Whiteboard: [inbound]
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
http://hg.mozilla.org/mozilla-central/rev/c023a6a059d1
You need to log in before you can comment on or make changes to this bug.