As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact
Last Comment Bug 662534 - Let imgRequestProxy implement nsITimedChannel, collect telemetry
: Let imgRequestProxy implement nsITimedChannel, collect telemetry
Product: Core
Classification: Components
Component: Networking (show other bugs)
: Trunk
: All All
: -- enhancement (vote)
: mozilla7
Assigned To: Honza Bambas (:mayhemer)
: Patrick McManus [:mcmanus]
Depends on:
Blocks: 658894
  Show dependency treegraph
Reported: 2011-06-07 08:01 PDT by Honza Bambas (:mayhemer)
Modified: 2011-06-10 02:55 PDT (History)
5 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

v1 (6.64 KB, patch)
2011-06-09 05:16 PDT, Honza Bambas (:mayhemer)
joe: review+
Details | Diff | Splinter Review

Description User image Honza Bambas (:mayhemer) 2011-06-07 08:01:41 PDT
In bug 658894 we collect some basic telemetry for a page load and its subrequests.  However, image requests are not included because imgRequetsProxy doesn't implement the new nsITimedChannel interface.

I have a patch for that already, will submit that for review after it passes try.
Comment 1 User image Honza Bambas (:mayhemer) 2011-06-09 05:16:16 PDT
Created attachment 538239 [details] [diff] [review]
Comment 2 User image Joe Drew (not getting mail) 2011-06-09 11:45:04 PDT
Comment on attachment 538239 [details] [diff] [review]

Review of attachment 538239 [details] [diff] [review]:

::: modules/libpr0n/src/imgRequestProxy.h
@@ +82,5 @@
> +  // nsITimedChannel declared bellow

Comment 3 User image Honza Bambas (:mayhemer) 2011-06-09 14:16:12 PDT
Landed as
Comment 4 User image Mounir Lamouri (:mounir) 2011-06-10 02:55:39 PDT

Note You need to log in before you can comment on or make changes to this bug.