Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jrmuizel, Assigned: jrmuizel)

Tracking

unspecified
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(firefox7 fixed)

Details

(Whiteboard: [qa-])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 537881 [details] [diff] [review]
Fix up fps code.

This fixes a couple of problems:

1. switches to a 32 bit type
2. adds a bit of documentation
3. frees the temporary buffer
Attachment #537881 - Flags: review?(joe)
Attachment #537881 - Attachment is patch: true
Attachment #537881 - Attachment mime type: text/x-patch → text/plain
Comment on attachment 537881 [details] [diff] [review]
Fix up fps code.

Review of attachment 537881 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/opengl/LayerManagerOGL.cpp
@@ +575,5 @@
>        0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,   0,
>      };
>  
> +    // convert from 8 bit to 32 bit so that we don't have to write the text out in 32 bit format
> +    // we rely on int being 32 bits */

please remove trailing */
Attachment #537881 - Flags: review?(joe) → review+
Assignee: nobody → jmuizelaar
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/mozilla-central/rev/3b95f57892ba and children
status-firefox7: --- → fixed

Updated

6 years ago
Blocks: 659860
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
> Fix up fps code.
> 
> This fixes a couple of problems:
> 
> 1. switches to a 32 bit type
> 2. adds a bit of documentation
> 3. frees the temporary buffer

What is "fps"?  First-person shooter?

I assume the temporary buffer was being leaked?  How big is it, how often was it being leaked?
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
"fps" is "Frames per second." This code lets us monitor how quickly we're drawing to the screen. It's not on by default, and, unless I am misremembering, before Jeff's changesets, it wasn't even possible to turn it on.

Did you have any reason to reopen this?
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Resolution: --- → FIXED
(Assignee)

Comment 5

6 years ago
We only leaked when a pref was set.
(In reply to comment #4)
> 
> Did you have any reason to reopen this?

It wasn't resolved, so I resolved it, but then I got cold feet because the link in comment 2 didn't seem to include the extra free() call that the attached patch did.  But I guess it went in in one of the changes not listed?

Comment 7

6 years ago
I was trying to see if this is fixed for Fx7 since the flag "status-firefox7" is set to "fixed", but I couldn't.
Is there a test case or any steps / guidelines for this bug that can be used to verify the fix? Thanks
qa-: no QA fix verification needed
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.