Last Comment Bug 662765 - Respect _M_IX86_FP
: Respect _M_IX86_FP
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: Trunk
: x86 Windows Vista
: -- normal (vote)
: mozilla7
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-08 04:03 PDT by Makoto Kato [:m_kato]
Modified: 2011-06-13 02:36 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (961 bytes, patch)
2011-06-08 04:03 PDT, Makoto Kato [:m_kato]
justin.lebar+bug: review+
Details | Diff | Review

Description Makoto Kato [:m_kato] 2011-06-08 04:03:29 PDT
Created attachment 537978 [details] [diff] [review]
fix

Although we don't use -arch:SSE2 or -arch:SSE option yet, we should handle _M_IX86_FP if available.
Comment 1 Justin Lebar (not reading bugmail) 2011-06-08 06:03:06 PDT
Comment on attachment 537978 [details] [diff] [review]
fix

>+  // It's ok to use SSE instructions based on the -arch option
>+  // It's ok to use SSE2 instructions based on the -arch option

Nit: It should be "/arch".

Aside from that, looks good to me.
Comment 2 Makoto Kato [:m_kato] 2011-06-13 02:36:28 PDT
http://hg.mozilla.org/mozilla-central/rev/b6f3d37f6fdb

Note You need to log in before you can comment on or make changes to this bug.