window.top.content is null (unable to view feed entries)

RESOLVED FIXED in seamonkey2.4

Status

SeaMonkey
MailNews: Message Display
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

Trunk
seamonkey2.4
Bug Flags:
in-testsuite -

SeaMonkey Tracking Flags

(seamonkey2.2 fixed, seamonkey2.3 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
+++ This bug was initially created as a clone of Bug #644983 +++

STR:
- install webtabs from http://jonathan.protzenko.free.fr/webtabs@momo.ca.xpi
- open a twitter tab
- switch to the main mail:3pane tab
- select multiple threads (so that you get the MultiMessageSummary)
- switch to the twitter tab
- switch back to the main mail:3pane tab
- click on one of your RSS feeds
- there should be a message displayed ; instead, the message pane is blank, and the error console reads

Error: window.top.content is null
Source File: chrome://messenger/content/mailWindowOverlay.js
Line: 3072

This happens *without* Thunderbird Conversations. Double-clicking on a feed item fixes the issue.
(Assignee)

Comment 1

6 years ago
Created attachment 538245 [details] [diff] [review]
Switch feed to use getBrowser [Checked in: Comment 4]

This patch:
* Ports fix from TB bug
* Matches position of early return with TB as comment in code suggests.
Attachment #538245 - Flags: review?(jh)
Comment on attachment 538245 [details] [diff] [review]
Switch feed to use getBrowser [Checked in: Comment 4]

I'm not an official MailNews reviewer, and don't know how to test the "broken" case, but feeds still seem to work with the patch applied, so f+ it is.
Attachment #538245 - Flags: review?(jh) → feedback+
(Assignee)

Updated

6 years ago
Attachment #538245 - Flags: review?(neil)

Comment 3

6 years ago
Comment on attachment 538245 [details] [diff] [review]
Switch feed to use getBrowser [Checked in: Comment 4]

Seems reasonable, although I think what's happening is that the Thunderbird conversations code must be messing with which browser is the active browser thus confusing the code that populates the content property.

[Why do we still have code using XPCNativeWrapper?]
Attachment #538245 - Flags: review?(neil) → review+
(Assignee)

Comment 4

6 years ago
Comment on attachment 538245 [details] [diff] [review]
Switch feed to use getBrowser [Checked in: Comment 4]

http://hg.mozilla.org/comm-central/rev/172703bbcfee
Attachment #538245 - Attachment description: Switch feed to use getBrowser → Switch feed to use getBrowser [Checked in: Comment 4]
(Assignee)

Updated

6 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.4

Comment 5

6 years ago
Comment on attachment 538245 [details] [diff] [review]
Switch feed to use getBrowser [Checked in: Comment 4]

Thunderbird patch landed on comm-aurora.
Attachment #538245 - Flags: approval-comm-aurora?
(Assignee)

Comment 6

6 years ago
Comment on attachment 538245 [details] [diff] [review]
Switch feed to use getBrowser [Checked in: Comment 4]

We probably want it on comm-beta too.
Attachment #538245 - Flags: approval-comm-beta?

Updated

6 years ago
Attachment #538245 - Flags: approval-comm-beta?
Attachment #538245 - Flags: approval-comm-beta+
Attachment #538245 - Flags: approval-comm-aurora?
Attachment #538245 - Flags: approval-comm-aurora+

Comment 7

6 years ago
Pushed:
http://hg.mozilla.org/releases/comm-aurora/rev/d586bcb76abd
http://hg.mozilla.org/releases/comm-beta/rev/9ac9d52ebeff

Updated

6 years ago
status-seamonkey2.2: --- → fixed
status-seamonkey2.3: --- → fixed
You need to log in before you can comment on or make changes to this bug.