Closed Bug 662870 Opened 8 years ago Closed 7 years ago

Use a native rendering for meter elements on MacOS X


(Core :: Widget: Cocoa, defect)

Not set





(Reporter: mounir, Assigned: mounir)


(Blocks 1 open bug)



(1 file, 2 obsolete files)

Attached patch WIP Patch (obsolete) — Splinter Review
I see three open questions:
 - What are the native sizes (for mini, small, regular widgets)?
 - Is there a native vertical style?
 - There are 4 styles, the most obvious one to use by default is continuous but do we want to allow the authors to use discrete, rating and relevancy ones? I would say not for the moment. Webkit allows that, see

Work in progress patch attached works but don't use native sizes (but progress ones) and don't takes into account vertical widget.
Attached patch Patch v1 (obsolete) — Splinter Review
There are three widget sizes (mini, small and regular) but all of them have the same size (height=16px).
I will write another patch for the vertical meter widget given that there is no native widget for that and I will have to rotate the widget in the implementation.
Attachment #538077 - Attachment is obsolete: true
Attachment #538255 - Flags: review?(joshmoz)
Blocks: 663119
Whiteboard: [needs review]
Attached patch Patch v1Splinter Review
Adding a test for RTL meter.
Attachment #538255 - Attachment is obsolete: true
Attachment #538255 - Flags: review?(joshmoz)
Attachment #538317 - Flags: review?(joshmoz)
Depends on: 663365
Attachment #538317 - Flags: review?(joshmoz) → review?(bgirard)
Benoit, can you do this review?
Comment on attachment 538317 [details] [diff] [review]
Patch v1

Review of attachment 538317 [details] [diff] [review]:

Attachment #538317 - Flags: review?(bgirard) → review+
Whiteboard: [needs review] → [ready to land][waits for dependencies]
Closed: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [ready to land][waits for dependencies]
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.