Canvas regression: Cannot draw image into canvas

VERIFIED FIXED in Firefox 6

Status

()

Core
Canvas: 2D
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: Mark D., Assigned: roc)

Tracking

({regression})

unspecified
mozilla7
regression
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox5- affected, firefox6- fixed)

Details

(URL)

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

6 years ago
User-Agent:       Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0) Gecko/20100101 Firefox/5.0
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:5.0) Gecko/20100101 Firefox/5.0

Cannot get canvas from canvas A, and draw it as an image into canvas B.

Reproducible: Always

Steps to Reproduce:
1. Visit http://radikalfx.com/files/collage/demo.html
2. Click search button on the bottom left
3. Click on an image

Actual Results:  
Image is not loaded into the canvas, instead there is an empty rectangle

Expected Results:  
Image is loaded into the canvas

Does not work in Firefox 5, or Firefox 7.0a1.
Works in Firefox 4.0.1, Safari, and Google Chrome

Comment 1

6 years ago
Regression window:
Works:
http://hg.mozilla.org/mozilla-central/rev/0798b52bb40d
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.2a1pre) Gecko/20110324 Firefox/4.2a1pre ID:20110324144234
Fails:
http://hg.mozilla.org/mozilla-central/rev/6a95db826e08
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.2a1pre) Gecko/20110324 Firefox/4.2a1pre ID:20110324145508
Pushlog:
http://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=0798b52bb40d&tochange=6a95db826e08
Blocks: 639689
Status: UNCONFIRMED → NEW
Component: General → Canvas: 2D
Ever confirmed: true
Keywords: regression
OS: Mac OS X → All
Product: Firefox → Core
QA Contact: general → canvas.2d
Hardware: x86_64 → All

Comment 2

6 years ago
FYI,
Toggle shadow off, then the image appears,
status-firefox5: --- → affected
tracking-firefox5: --- → ?

Comment 3

6 years ago
Bisected in local build,
Triggered by:
a34fe4ee349a	Robert O'Callahan — Bug 639689. Part 3: Remove unnecessary full context save/restore, and redundant SetPattern call. r=joe
Created attachment 538172 [details] [diff] [review]
fix
Assignee: nobody → roc
Attachment #538172 - Flags: review?(jmuizelaar)
I'll write a test for this when my tree is in a better state.
Attachment #538172 - Flags: review?(jmuizelaar) → review+
Keywords: checkin-needed
Whiteboard: [needs landing]
Created attachment 538685 [details] [diff] [review]
testcase
Attachment #538685 - Flags: review?(jmuizelaar)
http://hg.mozilla.org/integration/mozilla-inbound/rev/e01a18d61dd6

Once this lands on central, I would like to get it into ff5/beta if possible.
status-firefox6: --- → affected
tracking-firefox6: --- → ?
Keywords: checkin-needed
Whiteboard: [needs landing] → [inbound]
Backed out on m-i due to test_canvas.html failures:
http://hg.mozilla.org/integration/mozilla-inbound/rev/3d1b0a500fbf
Whiteboard: [inbound]
Created attachment 538795 [details] [diff] [review]
fix test failure

We need to make sure the input pattern is set correctly when we draw the shadow.
Attachment #538172 - Attachment is obsolete: true
http://hg.mozilla.org/integration/mozilla-inbound/rev/a858cef629f0
http://hg.mozilla.org/integration/mozilla-inbound/rev/70c1c696f691

I pushed the test on the assumption it will be OK. If Jeff doesn't like it we can change it later.
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/a858cef629f0
http://hg.mozilla.org/mozilla-central/rev/70c1c696f691
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
Comment on attachment 538795 [details] [diff] [review]
fix test failure

Probably too late for beta, but might as well draw the attention of release drivers.

This is a canvas regression in an edge case, but the fix is very simple.
Attachment #538795 - Flags: approval-mozilla-beta?
Attachment #538795 - Flags: approval-mozilla-aurora?
tracking-firefox5: ? → -

Comment 13

6 years ago
Comment on attachment 538795 [details] [diff] [review]
fix test failure

too late for beta. we'll evaluate for 6.
Attachment #538795 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
tracking-firefox6: ? → -
Attachment #538795 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [needs landing]
Attachment #538685 - Flags: review?(jmuizelaar) → review+
http://hg.mozilla.org/releases/mozilla-aurora/rev/e160897167a6
http://hg.mozilla.org/releases/mozilla-aurora/rev/3a6e0d66dc47
status-firefox6: affected → fixed
Whiteboard: [needs landing]
Flags: in-testsuite+
Duplicate of this bug: 667040

Updated

6 years ago
Duplicate of this bug: 668742

Comment 17

6 years ago
Bug 668742 is about that this issue is still present in the current Firefox 5 release.

Can we expect any improvement in a Firefox 5 update or do we need to wait until Firefox 6 is released?

Then I know what to tell to people on he support forum that have this problem in Firefox 5.

You can see a list of support threads that show this problem in Firefox 5, so we can expect to see a lot more reports about this issue.

(cross posting this in bug Bug 668742  as this bug is resolved)
> Can we expect any improvement in a Firefox 5 update or do we need to wait until > Firefox 6 is released?

Most likely the latter.  That should happen in mid-August....

Comment 19

6 years ago
Thanks for confirming that.
I was already expecting that (porting code to another branch is not easy), but a confirmation helps to avoid confusion and disappointment.
It's not just porting; there are just no plans to do any Firefox 5 updates before Firefox 6 ships unless a critical issue comes up; if one does an update would contain a fix for just that issue.

Once Firefox 6 ships, it becomes the security update to Firefox 5, with automatic updates from 5 to 6.
Mozilla/5.0 (Windows NT 5.1; rv:7.0) Gecko/20100101 Firefox/7.0

Verified on Win XP, Win 7, Ubuntu 11.04 and Mac OS X 10.6 using the STR from the description. Image is now loaded and can be dragged into the canvas.

Setting resolution to VERIFIED FIXED.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.