Closed Bug 662977 Opened 14 years ago Closed 14 years ago

File upload control needs a change event on drop

Categories

(Core :: Layout: Form Controls, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: darktrojan, Assigned: darktrojan)

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch patch (obsolete) — Splinter Review
Attachment #538162 - Flags: review?(bzbarsky)
Is there a reason this isn't using mTextFrame->CheckFireOnChange() like the filepicker codepath?
Attached patch patchSplinter Review
That reason might be "tried it, didn't work, found something that did". Turns out it was something else I was doing wrong. I told you I shouldn't hack layout.
Attachment #538162 - Attachment is obsolete: true
Attachment #538162 - Flags: review?(bzbarsky)
Attachment #538487 - Flags: review?(bzbarsky)
Geoff, maybe you could add a private SetFiles() (or the name you want) method doing all the file setting dance including the change event? Given that you basically copy-paste the code that is in CaptureMouseListener::MouseClick, I think it worth it.
Comment on attachment 538487 [details] [diff] [review] patch r=me, though bonus points for factoring the duplicated code out into a helper!
Attachment #538487 - Flags: review?(bzbarsky) → review+
(In reply to comment #4) > Geoff, maybe you could add a private SetFiles() (or the name you want) > method doing all the file setting dance including the change event? Given > that you basically copy-paste the code that is in > CaptureMouseListener::MouseClick, I think it worth it. I've just tried that, but they use different versions of nsHTMLInputElement::SetFiles. So I've given up.
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: