Note: There are a few cases of duplicates in user autocompletion which are being worked on.

File upload control needs a change event on drop

RESOLVED FIXED in mozilla7

Status

()

Core
Layout: Form Controls
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: darktrojan, Assigned: darktrojan)

Tracking

Trunk
mozilla7
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 538162 [details] [diff] [review]
patch
Attachment #538162 - Flags: review?(bzbarsky)

Comment 2

6 years ago
Is there a reason this isn't using mTextFrame->CheckFireOnChange() like the filepicker codepath?
(Assignee)

Comment 3

6 years ago
Created attachment 538487 [details] [diff] [review]
patch

That reason might be "tried it, didn't work, found something that did". Turns out it was something else I was doing wrong. I told you I shouldn't hack layout.
Attachment #538162 - Attachment is obsolete: true
Attachment #538162 - Flags: review?(bzbarsky)
Attachment #538487 - Flags: review?(bzbarsky)
Geoff, maybe you could add a private SetFiles() (or the name you want) method doing all the file setting dance including the change event? Given that you basically copy-paste the code that is in CaptureMouseListener::MouseClick, I think it worth it.

Comment 5

6 years ago
Comment on attachment 538487 [details] [diff] [review]
patch

r=me, though bonus points for factoring the duplicated code out into a helper!
Attachment #538487 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 6

6 years ago
(In reply to comment #4)
> Geoff, maybe you could add a private SetFiles() (or the name you want)
> method doing all the file setting dance including the change event? Given
> that you basically copy-paste the code that is in
> CaptureMouseListener::MouseClick, I think it worth it.

I've just tried that, but they use different versions of nsHTMLInputElement::SetFiles. So I've given up.
Keywords: checkin-needed
http://hg.mozilla.org/mozilla-central/rev/f47664f19b08
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Flags: in-testsuite?
You need to log in before you can comment on or make changes to this bug.