Closed
Bug 662977
Opened 14 years ago
Closed 14 years ago
File upload control needs a change event on drop
Categories
(Core :: Layout: Form Controls, defect)
Core
Layout: Form Controls
Tracking
()
RESOLVED
FIXED
mozilla7
People
(Reporter: darktrojan, Assigned: darktrojan)
Details
Attachments
(1 file, 1 obsolete file)
1.26 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•14 years ago
|
||
Attachment #538162 -
Flags: review?(bzbarsky)
![]() |
||
Comment 2•14 years ago
|
||
Is there a reason this isn't using mTextFrame->CheckFireOnChange() like the filepicker codepath?
Assignee | ||
Comment 3•14 years ago
|
||
That reason might be "tried it, didn't work, found something that did". Turns out it was something else I was doing wrong. I told you I shouldn't hack layout.
Attachment #538162 -
Attachment is obsolete: true
Attachment #538162 -
Flags: review?(bzbarsky)
Attachment #538487 -
Flags: review?(bzbarsky)
Comment 4•14 years ago
|
||
Geoff, maybe you could add a private SetFiles() (or the name you want) method doing all the file setting dance including the change event? Given that you basically copy-paste the code that is in CaptureMouseListener::MouseClick, I think it worth it.
![]() |
||
Comment 5•14 years ago
|
||
Comment on attachment 538487 [details] [diff] [review]
patch
r=me, though bonus points for factoring the duplicated code out into a helper!
Attachment #538487 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 6•14 years ago
|
||
(In reply to comment #4)
> Geoff, maybe you could add a private SetFiles() (or the name you want)
> method doing all the file setting dance including the change event? Given
> that you basically copy-paste the code that is in
> CaptureMouseListener::MouseClick, I think it worth it.
I've just tried that, but they use different versions of nsHTMLInputElement::SetFiles. So I've given up.
Keywords: checkin-needed
Comment 7•14 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Updated•14 years ago
|
Flags: in-testsuite?
You need to log in
before you can comment on or make changes to this bug.
Description
•