66301 - C style function callback change notification needs to be removed.

Status: RESOLVED WONTFIX

(Core :: Preferences: Backend, defect, P3)

Description

[Judson Valeski]

nsIPref has two listener/callback registration mechanisms causing confusion and 
inconsistency. The nsIObserver mechanism is preferred, and the old PrefCallback 
mechanism needs to be pulled out (and existing users of it need to be changed 
over to the new nsIObserver mechanism).

Comment 1

[Brian Nesse (gone)]

Bulk assigning bugs covered by the rewrite of nsPrefs to myself.

Comment 2

[Brian Nesse (gone)]

Bulk updating some fields and accepting

Comment 3

[Brian Nesse (gone)]

The C style callbacks are not supported for users nsIPrefBranch. This bug now
serves as a reminder that all current consumers of nsIPref need to be converted
to using nsIPrefService and nsIPrefBranch.

Comment 4

[Jussi-Pekka Mantere]

Bumping to 0.9.3.

Comment 5

[Brian Nesse (gone)]

Updating milestones

Comment 6

[Denis Antrushin]

Currently nsIPref is used in 208 files in about 10 modules...
Does it makes sense to file separate bugs for each module and then
make this one dependant on them? Otherwise patch is gonna be a way
too big

Comment 7

[Brian Nesse (gone)]

Yes, the removal of nsIPref is a big job. Filing separate bugs on the modules
and making this a meta bug would be a reasonable way to attack this. Especially
if the module owners would take ownership of their own cleanup. :)

Comment 8

[Alec Flett]

I don't think we can expect module owners to be responsible for converting their
own code, since this is such a well-used interface. We can request that they
start using the new API however :)

Comment 9

[Denis Antrushin]

But having separate (smaller!) bugs on modules you can get
some help outside. 
Also it'll be possible to get rid of it
step by step. Otherwise this bug will leave forever. :-)
Another point - having such bug assigned to module will
make it more visible to owners ;-)

Comment 10

[Brian Nesse (gone)]

Removing the 1.0 milestone to avoid having Asa do it for me. :)

Comment 11

[saari (gone)]

EDT topembed-, don't think it is a blocker. embed since it would still be nice
to have

Comment 12

[saari (gone)]

->peterl

Comment 13

[Peter Lubczynski]

--->reassign to default owner of prefs module

Comment 14

[sairuh (rarely reading bugmail)]

bnesse is no longer around. any takers?

Comment 15

[timeless]

90 callers, not exactly light lifting.

There are a few options.
* we could try and get each module owner to sign up to do the work
* we could inform the module owner that if they don't the work will be done for
them and their disinterest will be treated as moa for it.

cookie -- morse
pics -- can someone just let me cvs remove it?
wallet -- morse
typeahead -- aaronl -- this is new code, some sr's should be strung up for 
allowing it in, but aaronl knows.
security -- kaie
proxies -- darin
content [intl] -- smontagu
xulcache -- (jrgm?) -- i'll do it
dom [caret] -- aaronl
dom -- jst
gfx -- (each port) -- i'll do it
layout -- dbaron 
widget [mac] -- pinkerton
widget [xp] -- bryner
bootstrap [mac] -- pinkerton
search -- rjc
addrbook -- dmose

in short, i can do this work at my leisure, and will if people give me approval
in advance or some specific instructions for how to get prompt approval.

if you were cc'd and feel that i wrongfully selected you as being responsive for
some module, please indicate someone else.

the list is based on an lxr search for 'RegisterCallback'.

What i don't want to have to do is spend time hunting down or appologizing to
15module owners.

Comment 16

[Brian Ryner (not reading)]

I think this has a much better chance of getting done if you change all of the
callers yourself.  As far as I know I'm not the module owner of anything though.

Comment 17

[Alec Flett]

Frankly, since this is only on nsIPref, which is now deprecated in favor of
nsIPrefBranch / nsIPrefService - I would say this is just a WONTFIX. I don't see
the advantage of doing the work.

Comment 18

[Ioana (away)]

Removing QAwanted from this bug since it didn't come with any specific requests and it was added 12 years ago. Please re-add if you need anything specific from QA.

Comment 19

[Nicholas Nethercote [inactive]]

nsIPref is long gone. libpref still has two listener/callback registration mechanisms -- an observer one and a callback one -- but this is reasonable and not causing problems. WONTFIX.