663030 - Show a useful error message when the HTML Complete folder can't be written due to filename collision

Status: RESOLVED FIXED

(Camino Graveyard :: Downloading, defect)

Description

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Fix, v1

I ran into this when trying to determine if we used nsWebBrowserPersist.properties.  The testcase I used was the situation described in its "fileAlreadyExistsError", and I discovered we show a completely useless (generic) error message in that case.

This implements a more descriptive error message along the lines of the one used by nsWebBrowserPersist.cpp itself.

Forewarning: my coding brain is more than a bit rusty.

Comment 1

[Stuart Morgan]

Comment on attachment 538177 [details] [diff] [review]
Fix, v1

>+        NSString* fmtString = NSLocalizedString(@"DownloadErrorHTMLCompleteFolderIsFileFmt", @"");

Our style is nil for the second argument rather than @"" (the code you are basing this on is wrong/predates that decision).

Otherwise r/sr=me

Comment 2

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Follow-up: Local style cleanup

(In reply to comment #1)
> Comment on attachment 538177 [details] [diff] [review] [review]
> Fix, v1
> 
> >+        NSString* fmtString = NSLocalizedString(@"DownloadErrorHTMLCompleteFolderIsFileFmt", @"");
> 
> Our style is nil for the second argument rather than @"" (the code you are
> basing this on is wrong/predates that decision).
> 
> Otherwise r/sr=me

Bleh. Indeed, I used to know that rule before I went rusty.

Here's a follow-up patch that fixes the style of those strings, so that they're consistent (and current) in that method/file.

Comment 3

[Stuart Morgan]

Comment on attachment 540279 [details] [diff] [review]
Follow-up: Local style cleanup

sr=smorgan

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

http://hg.mozilla.org/camino/rev/75f768fc3c86
http://hg.mozilla.org/camino/rev/186690023a5a