663035 - Retrieving docShell of remote frames should simply return null instead of throwing

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

Retrieving docShell of remote frames should simply return null instead of throwing, otherwise code like "if (browser.docShell) .." can't be written.

I'm keeping the warning msg for now because it's been pretty useful to find breakage, but we should also remove it later.

Comment 1

[Benjamin Smedberg]

You prefer this instead of if (!browser.isRemote) { use browser.docShell }? I slightly prefer that way, but not enough to object here.

Comment 2

[:Felipe Gomes (needinfo for replies!)]

I do intend to keep this usage to a minimum.. but having a property that throws is a little unconventional. with the patch I don't have to ifdef out code like this:
http://mxr.mozilla.org/mozilla-central/source/browser/base/content/tabbrowser.xml#1522

Also, I was thinking of:
  <property name="isRemote" onget="return this.docShell == null"/>

because checking the attribute might give wrong results (if it was force disabled)

Or is there a better way to check that?

Comment 3

[:Felipe Gomes (needinfo for replies!)]

http://hg.mozilla.org/projects/electrolysis/rev/767e8a39d70b

Comment 4

[Marco Bonardo [:mak]]

I backed out everything from central since Android and Maemo were unhappy about the push these changes were part of.

Comment 5

[:Felipe Gomes (needinfo for replies!)]

http://hg.mozilla.org/mozilla-central/rev/258bc8fe5713