663038 - Set some preferences for e10s builds

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

Make builds built with --enable-e10s-compat to turn on e10s by default and disable hardware acceleration

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Use pref

(Was gonna post this in a separate bug but it seems unnecessary)

Uses the pref dom.ipc.tabs.enabled to create new tabs in the remote process.

This won't cover the first tab in the browser as the <browser> element is hard-coded in tabbrowser.. we'll need support to switch the remote="true" on/off for that

(and I think it's a good idea to leave the first tab as non-remote for the time being)

Comment 2

[Justin Dolske [:Dolske]]

Comment on attachment 538184 [details] [diff] [review]
Patch

Review of attachment 538184 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with addressing the one comment either way.

::: browser/app/profile/firefox.js
@@ +905,5 @@
> +#ifdef MOZ_E10S_COMPAT
> +pref("dom.ipc.tabs.enabled", true);
> +#else
> +pref("dom.ipc.tabs.enabled", false);
> +#endif

Hmm. I'm inclined to say that this pref should remain hidden, since we're still a ways from supporting Firefox in E10S. When we're farther along and want people to start testing and experimenting, then we can include it (still defaulted to false).

Alternatively, I think I'd be ok with only exposing the pref on Nightly builds.

Comment 3

[Justin Dolske [:Dolske]]

Comment on attachment 538189 [details] [diff] [review]
Use pref

Conversely to the above, this might as well be done without the #ifdef. If someone sets this pref, better to have stuff break right away than silently work unchanged until the day we un-ifdef this.

Comment 4

[Marco Bonardo [:mak]]

I backed out everything from central since Android and Maemo were unhappy about the push these changes were part of.

Comment 5

[:Felipe Gomes (needinfo for replies!)]

http://hg.mozilla.org/mozilla-central/rev/b12c57161b96