The default bug view has changed. See this FAQ.

Implement webNavigation for remote browsers

RESOLVED FIXED in mozilla8

Status

()

Core
Document Navigation
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Felipe, Assigned: Felipe)

Tracking

Trunk
mozilla8
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [e10s])

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 538186 [details] [diff] [review]
Patch v1

Simple patch v1 with implementation copied straight from mobile. Content-side support for it will come from bug 662008.

Still pondering if I should remove it from mobile or let it be overridden
(Assignee)

Comment 1

6 years ago
Created attachment 540196 [details] [diff] [review]
Patch

This just moves the remoteWebNavigation from mobile's browser.xml#remote-browser to toolkit's browser.xml

The getter in mobile is not removed so that it can skip the isRemoteBrowser check, as fennec has two different bindings for remote and non-remote browser.
Attachment #540196 - Flags: review?(dtownsend)
(Assignee)

Updated

6 years ago
Attachment #538186 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Attachment #540196 - Flags: review?(mark.finkle)
Attachment #540196 - Flags: review?(dtownsend) → review+
Comment on attachment 540196 [details] [diff] [review]
Patch

>diff --git a/toolkit/content/widgets/browser.xml b/toolkit/content/widgets/browser.xml

>+      <property name="isRemoteBrowser"
>+                onget="return (this.getAttribute('remote') == 'true');"
>+                readonly="true"/>
>+

Just wanted to note my disapproval of this kind of code. I think the dual binding approach serves us better.
Attachment #540196 - Flags: review?(mark.finkle) → review+
I backed out everything from central since Android and Maemo were unhappy about the push these changes were part of.
(Assignee)

Comment 4

6 years ago
Created attachment 544599 [details] [diff] [review]
Fix

Mark, this is why the back/forward, thumbnails and pinch-to-zoom broke. WebNav was renamed to _remoteWebNavigation with this patch, and the getter was updated, but this code was accessing the internal field instead of the public getter so it wasn't updating the correct object.
Attachment #544599 - Flags: review?(mark.finkle)
Attachment #544599 - Flags: review?(mark.finkle) → review+
(Assignee)

Comment 5

6 years ago
http://hg.mozilla.org/mozilla-central/rev/4fec0adad951
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla8
You need to log in before you can comment on or make changes to this bug.