Created attachment 538186 [details] [diff] [review]
Simple patch v1 with implementation copied straight from mobile. Content-side support for it will come from bug 662008.
Still pondering if I should remove it from mobile or let it be overridden
Created attachment 540196 [details] [diff] [review]
This just moves the remoteWebNavigation from mobile's browser.xml#remote-browser to toolkit's browser.xml
The getter in mobile is not removed so that it can skip the isRemoteBrowser check, as fennec has two different bindings for remote and non-remote browser.
Comment on attachment 540196 [details] [diff] [review]
>diff --git a/toolkit/content/widgets/browser.xml b/toolkit/content/widgets/browser.xml
>+ <property name="isRemoteBrowser"
>+ onget="return (this.getAttribute('remote') == 'true');"
Just wanted to note my disapproval of this kind of code. I think the dual binding approach serves us better.
I backed out everything from central since Android and Maemo were unhappy about the push these changes were part of.
Created attachment 544599 [details] [diff] [review]
Mark, this is why the back/forward, thumbnails and pinch-to-zoom broke. WebNav was renamed to _remoteWebNavigation with this patch, and the getter was updated, but this code was accessing the internal field instead of the public getter so it wasn't updating the correct object.