663040 - Implement webNavigation for remote browsers

Status: RESOLVED FIXED

(Core :: DOM: Navigation, defect)

Description

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch v1

Simple patch v1 with implementation copied straight from mobile. Content-side support for it will come from bug 662008.

Still pondering if I should remove it from mobile or let it be overridden

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Patch

This just moves the remoteWebNavigation from mobile's browser.xml#remote-browser to toolkit's browser.xml

The getter in mobile is not removed so that it can skip the isRemoteBrowser check, as fennec has two different bindings for remote and non-remote browser.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 540196 [details] [diff] [review]
Patch

>diff --git a/toolkit/content/widgets/browser.xml b/toolkit/content/widgets/browser.xml

>+      <property name="isRemoteBrowser"
>+                onget="return (this.getAttribute('remote') == 'true');"
>+                readonly="true"/>
>+

Just wanted to note my disapproval of this kind of code. I think the dual binding approach serves us better.

Comment 3

[Marco Bonardo [:mak]]

I backed out everything from central since Android and Maemo were unhappy about the push these changes were part of.

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Attachment: Fix

Mark, this is why the back/forward, thumbnails and pinch-to-zoom broke. WebNav was renamed to _remoteWebNavigation with this patch, and the getter was updated, but this code was accessing the internal field instead of the public getter so it wasn't updating the correct object.

Comment 5

[:Felipe Gomes (needinfo for replies!)]

http://hg.mozilla.org/mozilla-central/rev/4fec0adad951