Last Comment Bug 663090 - TI+JM: inline String.fromCharCode
: TI+JM: inline String.fromCharCode
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla10
Assigned To: Tom Schuster [:evilpie]
:
Mentors:
Depends on:
Blocks: 663087
  Show dependency treegraph
 
Reported: 2011-06-09 05:07 PDT by Jan de Mooij [:jandem]
Modified: 2012-12-12 10:25 PST (History)
5 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
v1 (7.24 KB, patch)
2011-10-30 10:17 PDT, Tom Schuster [:evilpie]
bhackett1024: review+
Details | Diff | Review

Description Jan de Mooij [:jandem] 2011-06-09 05:07:41 PDT
Should be pretty straight-forward, we inline charAt/charCodeAt already and charAt is basically charCodeAt + fromCharCode.
Comment 1 Tom Schuster [:evilpie] 2011-10-30 10:17:33 PDT
Created attachment 570559 [details] [diff] [review]
v1

Jan, I hope you don't mind me stealing this from you.
Indeed your work made this insanely easy.
Comment 2 Brian Hackett (:bhackett) 2011-10-30 20:14:51 PDT
Comment on attachment 570559 [details] [diff] [review]
v1

Review of attachment 570559 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsstr.cpp
@@ +2937,5 @@
>      }
>      return true;
>  }
>  
> +namespace js {

You can use js::str_fromCharCode instead of adding a 'namespace js'
Comment 3 Jan de Mooij [:jandem] 2011-10-31 00:58:18 PDT
(In reply to Tom Schuster (evilpie) from comment #1)
> Jan, I hope you don't mind me stealing this from you.

Sure, it's always okay to steal bugs I haven't touched in months :)
Comment 5 Mozilla RelEng Bot 2011-10-31 11:00:28 PDT
Try run for dbce6db06c3e is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=dbce6db06c3e
Results (out of 205 total builds):
    success: 198
    warnings: 7
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/evilpies@gmail.com-dbce6db06c3e
Comment 6 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-11-01 07:34:07 PDT
https://hg.mozilla.org/mozilla-central/rev/5625d3664e05

Note You need to log in before you can comment on or make changes to this bug.