The default bug view has changed. See this FAQ.

TI+JM: inline String.fromCharCode

RESOLVED FIXED in mozilla10

Status

()

Core
JavaScript Engine
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: jandem, Assigned: evilpie)

Tracking

unspecified
mozilla10
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

6 years ago
Should be pretty straight-forward, we inline charAt/charCodeAt already and charAt is basically charCodeAt + fromCharCode.
(Reporter)

Updated

6 years ago
Assignee: general → jandemooij
Status: NEW → ASSIGNED
(Assignee)

Comment 1

6 years ago
Created attachment 570559 [details] [diff] [review]
v1

Jan, I hope you don't mind me stealing this from you.
Indeed your work made this insanely easy.
Assignee: jandemooij → evilpies
Attachment #570559 - Flags: review?(bhackett1024)
Comment on attachment 570559 [details] [diff] [review]
v1

Review of attachment 570559 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsstr.cpp
@@ +2937,5 @@
>      }
>      return true;
>  }
>  
> +namespace js {

You can use js::str_fromCharCode instead of adding a 'namespace js'
Attachment #570559 - Flags: review?(bhackett1024) → review+
(Reporter)

Comment 3

6 years ago
(In reply to Tom Schuster (evilpie) from comment #1)
> Jan, I hope you don't mind me stealing this from you.

Sure, it's always okay to steal bugs I haven't touched in months :)
(Assignee)

Comment 4

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/5625d3664e05

Comment 5

6 years ago
Try run for dbce6db06c3e is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=dbce6db06c3e
Results (out of 205 total builds):
    success: 198
    warnings: 7
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/evilpies@gmail.com-dbce6db06c3e
https://hg.mozilla.org/mozilla-central/rev/5625d3664e05
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in before you can comment on or make changes to this bug.