Closed
Bug 663090
Opened 13 years ago
Closed 13 years ago
TI+JM: inline String.fromCharCode
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla10
People
(Reporter: jandem, Assigned: evilpie)
References
Details
Attachments
(1 file)
7.24 KB,
patch
|
bhackett1024
:
review+
|
Details | Diff | Splinter Review |
Should be pretty straight-forward, we inline charAt/charCodeAt already and charAt is basically charCodeAt + fromCharCode.
Reporter | ||
Updated•13 years ago
|
Assignee: general → jandemooij
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•13 years ago
|
||
Jan, I hope you don't mind me stealing this from you. Indeed your work made this insanely easy.
Assignee: jandemooij → evilpies
Attachment #570559 -
Flags: review?(bhackett1024)
Comment 2•13 years ago
|
||
Comment on attachment 570559 [details] [diff] [review] v1 Review of attachment 570559 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsstr.cpp @@ +2937,5 @@ > } > return true; > } > > +namespace js { You can use js::str_fromCharCode instead of adding a 'namespace js'
Attachment #570559 -
Flags: review?(bhackett1024) → review+
Reporter | ||
Comment 3•13 years ago
|
||
(In reply to Tom Schuster (evilpie) from comment #1) > Jan, I hope you don't mind me stealing this from you. Sure, it's always okay to steal bugs I haven't touched in months :)
Assignee | ||
Comment 4•13 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/5625d3664e05
Comment 5•13 years ago
|
||
Try run for dbce6db06c3e is complete. Detailed breakdown of the results available here: https://tbpl.mozilla.org/?tree=Try&rev=dbce6db06c3e Results (out of 205 total builds): success: 198 warnings: 7 Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/evilpies@gmail.com-dbce6db06c3e
https://hg.mozilla.org/mozilla-central/rev/5625d3664e05
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
You need to log in
before you can comment on or make changes to this bug.
Description
•