663090 - TI+JM: inline String.fromCharCode

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Jan de Mooij [:jandem]]

Should be pretty straight-forward, we inline charAt/charCodeAt already and charAt is basically charCodeAt + fromCharCode.

Comment 1

[Tom S. (please needinfo tschuster)]

Attachment: v1

Jan, I hope you don't mind me stealing this from you.
Indeed your work made this insanely easy.

Comment 2

[Brian Hackett [Laid off!]]

Comment on attachment 570559 [details] [diff] [review]
v1

Review of attachment 570559 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsstr.cpp
@@ +2937,5 @@
>      }
>      return true;
>  }
>  
> +namespace js {

You can use js::str_fromCharCode instead of adding a 'namespace js'

Comment 3

[Jan de Mooij [:jandem]]

(In reply to Tom Schuster (evilpie) from comment #1)
> Jan, I hope you don't mind me stealing this from you.

Sure, it's always okay to steal bugs I haven't touched in months :)

Comment 4

[Tom S. (please needinfo tschuster)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/5625d3664e05

Comment 5

[Mozilla RelEng Bot]

Try run for dbce6db06c3e is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=dbce6db06c3e
Results (out of 205 total builds):
    success: 198
    warnings: 7
Builds available at http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-dbce6db06c3e

Comment 6

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

https://hg.mozilla.org/mozilla-central/rev/5625d3664e05