Add test coverage for tablist as implicit live region

RESOLVED FIXED

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: davidb, Assigned: davidb)

Tracking

(Blocks: 2 bugs)

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Noticed this just now during W3 call. Trivial patch coming.
(Assignee)

Comment 1

6 years ago
Created attachment 538268 [details] [diff] [review]
patch
Attachment #538268 - Flags: review?(marco.zehe)
Comment on attachment 538268 [details] [diff] [review]
patch

r=me with this question answered/fixed:

>+  <div id="tablist" role="tablist">tablist <div id="tablistChild">tab</div></div>

Any reason you didn't give that child a role of "tab"? Was that intentional? If so, why?
Attachment #538268 - Flags: review?(marco.zehe) → review+
(Assignee)

Comment 3

6 years ago
(In reply to comment #2)
> Comment on attachment 538268 [details] [diff] [review] [review]
> patch
> 
> r=me with this question answered/fixed:
> 
> >+  <div id="tablist" role="tablist">tablist <div id="tablistChild">tab</div></div>
> 
> Any reason you didn't give that child a role of "tab"? Was that intentional?
> If so, why?

Intentional. Leaving it off made it explicit that it didn't matter what the child was. I think if we later require the children to be tabs for the container-foo to work we should test for, and absence of, role=tab on the child. Make sense?
Perfect, thanks!
landed http://hg.mozilla.org/mozilla-central/rev/4436b2bc5f64
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.