Closed
Bug 663136
Opened 14 years ago
Closed 14 years ago
Add test coverage for tablist as implicit live region
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
People
(Reporter: davidb, Assigned: davidb)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
|
4.55 KB,
patch
|
MarcoZ
:
review+
|
Details | Diff | Splinter Review |
Noticed this just now during W3 call. Trivial patch coming.
|
Assignee | |
Comment 1•14 years ago
|
||
Attachment #538268 -
Flags: review?(marco.zehe)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 538268 [details] [diff] [review]
patch
r=me with this question answered/fixed:
>+ <div id="tablist" role="tablist">tablist <div id="tablistChild">tab</div></div>
Any reason you didn't give that child a role of "tab"? Was that intentional? If so, why?
Attachment #538268 -
Flags: review?(marco.zehe) → review+
|
|
Assignee | |
Comment 3•14 years ago
|
||
(In reply to comment #2)
> Comment on attachment 538268 [details] [diff] [review] [review]
> patch
>
> r=me with this question answered/fixed:
>
> >+ <div id="tablist" role="tablist">tablist <div id="tablistChild">tab</div></div>
>
> Any reason you didn't give that child a role of "tab"? Was that intentional?
> If so, why?
Intentional. Leaving it off made it explicit that it didn't matter what the child was. I think if we later require the children to be tabs for the container-foo to work we should test for, and absence of, role=tab on the child. Make sense?
|
|
||
Comment 4•14 years ago
|
||
Perfect, thanks!
|
||
Comment 5•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•