Last Comment Bug 663136 - Add test coverage for tablist as implicit live region
: Add test coverage for tablist as implicit live region
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: David Bolter [:davidb]
:
:
Mentors:
Depends on:
Blocks: aria a11ytestdev
  Show dependency treegraph
 
Reported: 2011-06-09 08:31 PDT by David Bolter [:davidb]
Modified: 2011-06-13 04:14 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (4.55 KB, patch)
2011-06-09 08:35 PDT, David Bolter [:davidb]
mzehe: review+
Details | Diff | Splinter Review

Description David Bolter [:davidb] 2011-06-09 08:31:59 PDT
Noticed this just now during W3 call. Trivial patch coming.
Comment 1 David Bolter [:davidb] 2011-06-09 08:35:00 PDT
Created attachment 538268 [details] [diff] [review]
patch
Comment 2 Marco Zehe (:MarcoZ) 2011-06-09 11:55:16 PDT
Comment on attachment 538268 [details] [diff] [review]
patch

r=me with this question answered/fixed:

>+  <div id="tablist" role="tablist">tablist <div id="tablistChild">tab</div></div>

Any reason you didn't give that child a role of "tab"? Was that intentional? If so, why?
Comment 3 David Bolter [:davidb] 2011-06-09 11:57:09 PDT
(In reply to comment #2)
> Comment on attachment 538268 [details] [diff] [review] [review]
> patch
> 
> r=me with this question answered/fixed:
> 
> >+  <div id="tablist" role="tablist">tablist <div id="tablistChild">tab</div></div>
> 
> Any reason you didn't give that child a role of "tab"? Was that intentional?
> If so, why?

Intentional. Leaving it off made it explicit that it didn't matter what the child was. I think if we later require the children to be tabs for the container-foo to work we should test for, and absence of, role=tab on the child. Make sense?
Comment 4 Marco Zehe (:MarcoZ) 2011-06-09 11:59:58 PDT
Perfect, thanks!
Comment 5 Trevor Saunders (:tbsaunde) 2011-06-13 04:14:26 PDT
landed http://hg.mozilla.org/mozilla-central/rev/4436b2bc5f64

Note You need to log in before you can comment on or make changes to this bug.