Closed Bug 663136 Opened 12 years ago Closed 12 years ago

Add test coverage for tablist as implicit live region

Categories

(Core :: Disability Access APIs, defect)

Product:
Core
Component:
Disability Access APIs
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: davidb, Assigned: davidb)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

patch
4.55 KB, patch
MarcoZ
: review+
Details | Diff | Splinter Review 
Noticed this just now during W3 call. Trivial patch coming.
Attached patch patch — — Splinter Review 

        Attachment #538268 -
        Flags: review?(marco.zehe)

    
    

    
  
Comment on attachment 538268 [details] [diff] [review]
patch

r=me with this question answered/fixed:

>+  <div id="tablist" role="tablist">tablist <div id="tablistChild">tab</div></div>

Any reason you didn't give that child a role of "tab"? Was that intentional? If so, why?

        Attachment #538268 -
        Flags: review?(marco.zehe) → review+

    
    

    
  
(In reply to comment #2)
> Comment on attachment 538268 [details] [diff] [review] [review]
> patch
> 
> r=me with this question answered/fixed:
> 
> >+  <div id="tablist" role="tablist">tablist <div id="tablistChild">tab</div></div>
> 
> Any reason you didn't give that child a role of "tab"? Was that intentional?
> If so, why?

Intentional. Leaving it off made it explicit that it didn't matter what the child was. I think if we later require the children to be tabs for the container-foo to work we should test for, and absence of, role=tab on the child. Make sense?

    
    

    
  
Perfect, thanks!

    
    

    
  
landed http://hg.mozilla.org/mozilla-central/rev/4436b2bc5f64
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.