663182 - Follow-up: UI for about:sync-log

Status: NEW

(Firefox :: Sync, defect)

Description

[Richard Newman [:rnewman]]

We now persist a directory full of sync logs. It would be nice to have a UI on top of this, a la about:crashes.

Comment 1

[Richard Newman [:rnewman]]

See Bug 610832, particularly comment 18, for more background on this.

Comment 2

[Philipp von Weitershausen [:philikon]]

This will probably tie into Syncorro, which makes this not so good-first-bug-y, nor will it be polish.

Comment 3

[Mime Čuvalo]

Attachment: sync-log ui (based on syncorro) v.1

The only thing missing as far AFAIK is the default URL pref to submit to a server somewhere.

Also, I added a link from about:support for kicks - lemme know whatchya think.

Comment 4

[Philipp von Weitershausen [:philikon]]

Comment on attachment 595437 [details]
sync-log ui (based on syncorro) v.1

Nice. Can you post a screenshot?

Comment 5

[Mime Čuvalo]

Attachment: screenshot of detail view

Comment 6

[Mime Čuvalo]

Related question: so, now there are logs in
weave/logs  and 
weave/syncorro
the former being in .txt format with just the raw log, the latter in .json format with more details.  Perhaps if this lands there wouldn't be a need for weave/logs anymore?

Comment 7

[Philipp von Weitershausen [:philikon]]

(In reply to Mime Cuvalo from comment #6)
> Related question: so, now there are logs in
> weave/logs  and 
> weave/syncorro
> the former being in .txt format with just the raw log, the latter in .json
> format with more details.  Perhaps if this lands there wouldn't be a need
> for weave/logs anymore?

So, I took a closer look at the patch. It mostly just copies stuff from the experimental Syncorro add-on. I didn't realize Syncorro was far along already for that. It seems to blow the purpose of this bug out of proportion a bit...

Because Syncorro was conceived as a separate add-on, it invented a lot of parallel structures to the Sync code. The "Syncorro" object was never meant to survive in the long run. Please integrate it with ErrorHandler in policies.js. (If for some reason that's not practical, please just add another policy object to policies.js.) Same goes for the logs: we should keep the log files in weave/logs and not include the log text in the JSON. The JSON files and the .txt files could live side by side in weave/logs, *if* about:sync-log is no longer just a directory listing. That way we can also have the ErrorHandler perform the automatic clean up on the JSON files.

Anyway, I'm a bit perplexed that we're rushing Syncorro into the code now, but perhaps I'm misunderstanding this. I personally would suggest that we wrap up Syncorro first as a "beta" add-on, deploy an ElasticSearch to a test server somewhere, and iterate for a few weeks with some user testing (could easily get ~1000 beta testers).

Comment 8

[Mime Čuvalo]

Correct, so it's mostly the Syncorro add-on code - sorry, I had the impression that this would eventually be about:sync-log judging from what it said on the wiki ( https://wiki.mozilla.org/Services/Sync/FxSync/Syncorro#Looking_up_error_reports )

I wasn't sure what else to change on Syncorro so Mike suggested I start creating a patch for integration.  I still can't test with a remote Elastic server, I'm waiting for Daniel on that (see bug 673318) - he says they're in the midst of a migration so best to hold off.

I'll take a look at policies.js  Is there a good reason though that the .txt and .json files should just live side by side?  Are those .txt files being used anywhere else?

I'm ok with just doing the add-on for now - it's up to you guys - it's the same to me.  Just was unclear on what else to change on Syncorro in the meantime.