663187 - about:support should display plugins preferences

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[Benoit Girard (:BenWa)]

I spent a long time investigating the difference between two profile. Turns out one profile had a new preference (rather then an added preference). These should show up in about:support.

Comment 1

[Josh Matthews [:jdm]]

I believe that there's a whitelist of preferences that show up on about:support, instead of a general free for all of non-default values.

Comment 2

[Benoit Girard (:BenWa)]

I would like to know why this decision was made because this process is very error prone, like in my case. Does any one know for sure?

Comment 3

[Josh Matthews [:jdm]]

See http://mxr.mozilla.org/mozilla-central/source/toolkit/content/aboutSupport.js#48 and bug 631909.

Comment 4

[Benoit Girard (:BenWa)]

Thanks for the info Josh, I'll add a patch with the relevant prefs we are missing. It's not ideal but I can see why privacy trumps it.

Comment 5

[Benoit Girard (:BenWa)]

Attachment: Add plugin prefs to about:support

Comment 6

[Benoit Girard (:BenWa)]

Attachment: Add plugin prefs to about:support

This unhides the properties we care about for plugins.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 539603 [details] [diff] [review]
Add plugin prefs to about:support

I don't see any existing prefs under "mozilla.plugins.", why did you add that?

With the possible exception of "plugin.override_internal_types", I don't see which relevant prefs are covered by the "plugin[s]." rules. Which pref caused you to file this bug?

Comment 8

[Benoit Girard (:BenWa)]

I just checked with mxr and the only use of 'mozilla.plugins.' is 'mozilla.plugins.use_layers'. I could be convinced to rename that preference instead.

With plugin[s] I'm just hoping to catch anything unusual that sometimes makes debugging easier.

Comment 9

[Benoit Girard (:BenWa)]

Forgot the link:
http://mxr.mozilla.org/mozilla-central/source/dom/plugins/base/nsNPAPIPluginInstance.cpp#107

Comment 10

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #8)
> I just checked with mxr and the only use of 'mozilla.plugins.' is
> 'mozilla.plugins.use_layers'. I could be convinced to rename that preference
> instead.

Oh, weird - didn't notice it because it has no default. It's an odd pref name ("mozilla" is redundant, and we already had prefs under plugin.*). I think it should be changed, assuming no one would have come to rely on it?

Comment 11

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 539603 [details] [diff] [review]
Add plugin prefs to about:support

Let's rename the pref and just add "plugin" to the whitelist.

Comment 12

[Benoit Girard (:BenWa)]

Attachment: Add 'plugin', 'plugins' prefs to about:support

(In reply to comment #11)
> Let's rename the pref and just add "plugin" to the whitelist.

I renamed the pref. I'm also suggesting we add 'plugins'.

Comment 13

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 543252 [details] [diff] [review]
Add 'plugin', 'plugins' prefs to about:support

I was suggesting that you just add "plugin" (without the dot) to cover both, but I suppose this might be clearer.

Comment 14

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/46614167ca6a

Comment 15

[Mounir Lamouri (:mounir)]

Merged:
http://hg.mozilla.org/mozilla-central/rev/46614167ca6a