Open Bug 663339 Opened 13 years ago Updated 2 years ago
Remove the double-flip hack in Cocoa widget added for Mac
OS 10 .4
We don't support 10.4 anymore so you should probably not worry about that and save some cycles.
Attachment #538464 - Flags: review?(mstange)
Whiteboard: [needs review]
By "you", I meant "we".
Comment on attachment 538464 [details] [diff] [review] Patch v1 Looks like this works in principle, but this patch on its own changes the vertical position of some buttons. For example the regular-sized buttons on the General preferences pane are two pixels higher. It may well be that there's a bug in the current flipping code and that we're passing in wrong margins; but whatever causes the difference, it needs to be fixed before we can land this patch.
Attachment #538464 - Flags: review?(mstange) → review-
The code used to render the button seems old and hacky: the button doesn't take the entire frame and |pushButtonSettings| doesn't even seems up to date. Interface Builder gives me different values for the height. Though, changing them makes it worse :(
Now you know why I've been reluctant to touch that code :)
(In reply to comment #4) > Now you know why I've been reluctant to touch that code :) Eh :) I will keep this bug open and will get back to it some day or another. I'm not using a Mac in my day to day work so it might take some time before I work on it. Though, I like to distract myself with that kind of bug :)
MacOs 10.4 is no longer supported.
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → INCOMPLETE
(In reply to opi123 from comment #6) > MacOs 10.4 is no longer supported. Yes. This bug is dealing with removal of code that we no longer need.
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
You need to log in before you can comment on or make changes to this bug.