663400 - Changing view causes an error "this.tabbox is null"

Status: RESOLVED FIXED

(Calendar :: Calendar Frontend, defect)

Description

[Decathlon]

I was quite sure this bug had already been reported but I can't find it.

Steps to reproduce:
1. in calendar view click on a different tab in order to switch view (day,
   week, multiweek, month), sometimes more than once;

-> in the error console appears the error:

   Error: this.tabbox is null
   Source File: chrome://global/content/bindings/tabbox.xml
   Line: 476

Maybe related to bug 596759?

Comment 1

[Christophe Seguinot]

I get the error causing ALL calendar events not being displayed in week view (other views are correctly rendered). All worked fine before upgrading. 

(I use Thunderbird 5.0 + lightning 1.04b)

Comment 2

[Christophe Seguinot]

Finally, after reloading, the error message remains, but display is now correct.

Comment 3

[Decathlon]

Attachment: fix - v1

Patch for bug 596759 highlighted the issue.
This patch fixes, but I'm not sure whether it's formally corrected to leave the box with class="navigation-bottombox" inside the tabbox.

Comment 4

[Philipp Kewisch [:Fallen][☁️📆]]

Comment on attachment 569526 [details] [diff] [review]
fix - v1

What we are doing with those tabs isn't formally correct anyways ;-) The <tabbox> should have a <tabpanels> child, so don't worry about the bottombox.

I've locally added a few style fixes for mac, there are some mac-specific tabbox rules that need overwriting. I've looked into windows/linux themes and they don't have such rules.

Comment 5

[Philipp Kewisch [:Fallen][☁️📆]]

comm-central changeset 2f1b2dd6d46c
releases/comm-aurora changeset 7e5f83a83229
releases/comm-beta changeset 8898520a1258