663444 - Non-ASCII bugmail subjects are mangled

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Jesse Ruderman]

Since this broke between yesterday and today, I'm assuming it's a regression from bug 650575 or from me selecting the option added by bug 650575.  I read bugmail using Gmail.


Old bugmail displays correctly:

Subject: [Bug 404416] Show keyboard shortcuts
 (=?UTF-8?Q?=E2=8C=981=20through=20=E2=8C=989?=) in the "All Tabs" menu

[Bug 404416] Show keyboard shortcuts (⌘1 through ⌘9) in the "All Tabs" menu


New bugmail displays incorrectly:

Subject: [Bug 404416] Show keyboard shortcuts (�1 through �9) in the "All
 Tabs" menu

[Bug 404416] Show keyboard shortcuts (ā1 through ā9) in the "All Tabs" menu

Comment 1

[:glob ✱]

weird... utf subjects still look ok for me using my gmail testing account when the new preference is enabled.

however, looking at the source, the escaping is no longer happening, so there's definitely a problem here.

Comment 2

[:glob ✱]

Attachment: patch v1

the message headers are encoded before they hit the mailer_before_send hook, and Email::MIME automatically decodes the header values when you get them.

we have to manually encode the subject after modifying it.

Comment 3

[David Lawrence [:dkl]]

Comment on attachment 538557 [details] [diff] [review]
patch v1

Review of attachment 538557 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me. r=dkl

Comment 4

[:glob ✱]

this fix has been checked in (revision 7763).