Closed
Bug 663455
Opened 13 years ago
Closed 13 years ago
IonMonkey: add functionality useful for dataflow analyses
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
People
(Reporter: rpearl, Assigned: rpearl)
Details
Attachments
(1 file, 1 obsolete file)
3.50 KB,
patch
|
adrake
:
review+
|
Details | Diff | Splinter Review |
For computing available expression sets, we must perform set intersection, and see if the intersection changed anything (that is, we haven't reached a fixed point in the analysis yet). We can trivially do so in one pass, rather than doing a subset check and then performing intersection.
Assignee | ||
Comment 1•13 years ago
|
||
Comment on attachment 538551 [details] [diff] [review] implements intersection + fixedpoint test Review of attachment 538551 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/ion/BitSet.cpp @@ +122,5 @@ > } > + > +// returns true if the intersection caused the contents of the set to change. > +bool BitSet::fixedPointIntersect(const BitSet *other) > +{ Drive-by style nit, the type gets its own line: bool BitSet::fixedPointIntersect(const BitSet *other)
Comment 3•13 years ago
|
||
Comment on attachment 538551 [details] [diff] [review] implements intersection + fixedpoint test Review of attachment 538551 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! r+ with dvander's nits addressed.
Comment 4•13 years ago
|
||
Comment on attachment 538551 [details] [diff] [review] implements intersection + fixedpoint test Review of attachment 538551 [details] [diff] [review]: ----------------------------------------------------------------- Looks good! r+ with dvander's nits addressed.
Attachment #538551 -
Flags: review?(adrake) → review+
Assignee | ||
Comment 5•13 years ago
|
||
This fixes the nit--I ask for a new review because I've added complement, also needed by my analysis phase.
Attachment #538551 -
Attachment is obsolete: true
Attachment #538601 -
Flags: review?(adrake)
Assignee | ||
Updated•13 years ago
|
Summary: IonMonkey: add fixed-point test during intersection → IonMonkey: add functionality useful for dataflow analyses
Comment 6•13 years ago
|
||
Comment on attachment 538601 [details] [diff] [review] new patch (added functionality) Review of attachment 538601 [details] [diff] [review]: ----------------------------------------------------------------- Looks good with that comment added. ::: js/src/ion/BitSet.h @@ +103,5 @@ > + // O(max): Intersect this set with the given set; return whether the > + // intersection caused the set to change. > + bool fixedPointIntersect(const BitSet *other); > + > + void complement(); Could we get a comment like the ones on the other functions on this?
Attachment #538601 -
Flags: review?(adrake) → review+
Assignee | ||
Comment 7•13 years ago
|
||
http://hg.mozilla.org/users/danderson_mozilla.com/ionmonkey/rev/fd48b9858f74
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•