663629 - Home button does nothing (Error: nsIPrefLocalizedString is not defined), Also Translate Page, etc, etc.

Status: VERIFIED FIXED

(SeaMonkey :: General, defect)

Description

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; Linux x86_64; rv:7.0a1) Gecko/20110611 Firefox/7.0a1 SeaMonkey/2.4a1 ID:20110611003105

After a series of startup crashes, I changed my settings as follows:
- Open a blank page at browser startup
- Open a blank page on a new window
- Open a blank page on a new tab
My multitab homepage is still set, as can be ascertained from preferences browser.startup.homepage, browser.startup.homepage.1, ..., browser.startup.homepage.132; and browser.startup.homepage.count is set to 133; these are also shown in "Edit → Preferences → Browser → *Home Page* Clicking the Home button takes you to this group of pages".

BUT when I click the Home button (which is shaped like a house), nothing happens. I also notice that it has no tooltip (hovering the mouse over it brings up an empty balloon, maybe 4px high, width varies with theme let's say 4px to 6px, no text).

Behaviour is identical in all three of SeaMonkey Default Theme, SeaMonkey Modern, and my usual EarlyBlue, even in Safe Mode.

Comment 1

[Tony Mechelynck [:tonymec]]

Experiment:
1. Set "New Window" to open "Home Page"
2. File → New → Browser window
---> A new window opens with a single, blank, tab.
3. Close that empty window.
4. Restart by changing theme and clicking "Restart Now"
5. File → New → Browser window
---> A new window opens with a single, blank, tab.
6. Ctrl+Q, wait, launch SeaMonkey
7. File → New → Browser window
---> A window opens with a single, blank, tab.

Comment 2

[Tony Mechelynck [:tonymec]]

New experiment:
1. Set "New Window" back to "Blank Page" and "Browser Startup" to "Home Page"
2. Ctrl+Q, wait, launch SeaMonkey
---> Multitab homepage opens
3. File → New → Browser window
---> A window opens with a single, blank, tab. (Unlike in comment #1, this is expected.)
---> Home button still does nothing and still has no tooltip.

Comment 3

[Philip Chee]

The try/catch block in getHomePage() eats errors such as:
nsIPrefLocalizedString is not defined

The Tools->Translate Page item is also affected.
Error: nsIPrefLocalizedString is not defined
Source file: chrome://navigator/content/navigator.js
Line: 837

Regression from Bug 662162 - Create helper function for getting nsIPrefLocalizedString complexvalue prefs

Comment 4

[Ian Neal]

Attachment: Switch navigator.js to use new GetLocalizedStringPref helper [Checked in: Comment 5]

This was sitting in my tree, meant to get it reviewed and checked in before now.
Switches navigator.js to use the new helper GetLocalizedStringPref

Comment 5

[Ian Neal]

Comment on attachment 538710 [details] [diff] [review]
Switch navigator.js to use new GetLocalizedStringPref helper [Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/22ca502d734c

Comment 6

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; Linux x86_64; rv:7.0a1) Gecko/20110610 Firefox/7.0a1 SeaMonkey/2.4a1 ID:20110611134428

In this tinderbox-build, the Home button has recovered its tooltip, with all my home tabs in it (or as many of them as fit onscreen), and clicking it opens them.

Tools → Translate Page doesn't work on this https page, but I tried it on a page I had in thirteenth-century French, with amusing results, which show that the Google translation engine is trying (and sometimes even succeeding) to understand that middle-French (or is it old-French?) text.

I'm setting this bug to VERIFIED on the assumption that it is platform-agnostic. Feel free to REOPEN if you still see the bug in a build *started* after comment #5 (and check e.g. the 14-digit "Build ID" datestamp as shown by the Nightly Tester Tools extension or in a crash report). Or if you see it in the 2011-06-12 nightly, when it will exist.