Search plugins don't work with the post method

RESOLVED WORKSFORME

Status

--
major
RESOLVED WORKSFORME
18 years ago
8 years ago

People

(Reporter: Erich.Iseli, Unassigned)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
In sherlock search plugins, you have the following element

<search
    name="..."
    description="..."
    method="..."   <========
    action="..."
    >

The method usually used is "get" but obviously, "post" should also be possible.
However, if you do that, the plugin won't work at all if you use the web form to
post the search (no results get displayed in the sidebar) or if you type your
search into the sidebar, it will load search.netscape.com instead of the correct
search enginge. Note that Netscape search is used _even_ if the default search
engine is an other one (for example Google).

This prevents you from using sherlock plugins for many search engines that use
the post method (=> severity: major).

The URL above sends you to a testcase. Plugins and a dummy search engine are
available there.
Note to matt: 95+% of public search engines out there use HTTP GET...

With the current architecture, there is no easy solution for providing full
support for HTTP POST. Good luck!  (I'd mark this bug as low severity.)

Comment 2

18 years ago
Nice to have, but don't think we'll get to this for beta1. Marking nsbeta1-, future
Keywords: nsbeta1-
Target Milestone: --- → Future

Comment 3

17 years ago
reassigning matt's old bugs to default owner.
Assignee: matt → sgehani
(Reporter)

Updated

17 years ago
Blocks: 126089
(Reporter)

Updated

17 years ago
Depends on: 172120
(Reporter)

Updated

17 years ago
Blocks: 172120
No longer depends on: 172120

Comment 4

13 years ago
Created attachment 227715 [details] [diff] [review]
mozilla-firefox-1.5.0.4_post-method-search.patch

I made a tiny hack for gentoos mozilla-firefox-1.5.0.4-ebuild, that generates HTTP POST-requests, carrying url-encoded form-data in their body, when the "method"-field within the search plugin src-file is set to "POST".

This is not very pretty, akin the rest of the search-functionality, but seems to do the job.

see also: https://bugs.gentoo.org/show_bug.cgi?id=138577
(Assignee)

Updated

11 years ago
Product: Core → SeaMonkey
Assignee: samir_bugzilla → nobody
QA Contact: claudius → search
Target Milestone: Future → ---

Updated

10 years ago
Depends on: 410613

Comment 5

8 years ago
Fixed in bug 410613

Updated

8 years ago
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.