Last Comment Bug 663662 - "ASSERTION: Weird break found" with rtl, -moz-column
: "ASSERTION: Weird break found" with rtl, -moz-column
: assertion, regression, testcase
Product: Core
Classification: Components
Component: Layout: Text (show other bugs)
: 7 Branch
: x86_64 Mac OS X
-- normal (vote)
: mozilla7
Assigned To: Simon Montagu :smontagu
Depends on:
Blocks: randomstyles textfuzzer 263359
  Show dependency treegraph
Reported: 2011-06-11 15:30 PDT by Jesse Ruderman
Modified: 2011-09-22 15:09 PDT (History)
7 users (show)
smontagu: in‑testsuite+
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

testcase (336 bytes, text/html)
2011-06-11 15:30 PDT, Jesse Ruderman
no flags Details
stack traces (30.84 KB, text/plain)
2011-06-11 15:31 PDT, Jesse Ruderman
no flags Details
Patch (2.71 KB, patch)
2011-06-14 00:34 PDT, Simon Montagu :smontagu
roc: review+
Details | Diff | Splinter Review

Description User image Jesse Ruderman 2011-06-11 15:30:59 PDT
Created attachment 538725 [details]

###!!! ASSERTION: Weird break found!: 'limitLength >= 0', file layout/generic/nsTextFrameThebes.cpp, line 6824

###!!! ASSERTION: Invalid offset: 'aOffset <= mSkipChars->mCharCount', file gfx/thebes/gfxSkipChars.cpp, line 92

###!!! ASSERTION: negative length: 'GetContentEnd() - mContentOffset >= 0', file layout/generic/nsTextFrame.h, line 327

###!!! ASSERTION: integer overflow: 'mMaxTextLength < PR_UINT32_MAX - aFrame->GetContentLength()', file layout/generic/nsTextFrameThebes.cpp, line 1437

Regression from bug 263359, I think.
Comment 1 User image Jesse Ruderman 2011-06-11 15:31:23 PDT
Created attachment 538726 [details]
stack traces
Comment 2 User image :Ehsan Akhgari 2011-06-13 13:32:41 PDT
Security regression from something landed for Firefox 7, should be tracked.
Comment 3 User image Simon Montagu :smontagu 2011-06-14 00:34:20 PDT
Created attachment 539148 [details] [diff] [review]

This came from not checking the definition of which characters constitute a forced line break in CSS.
Comment 4 User image Jesse Ruderman 2011-06-14 00:45:42 PDT
As assertion from a spec violation? Is that because other parts of Gecko check the right thing?
Comment 5 User image Simon Montagu :smontagu 2011-06-14 00:53:59 PDT
Yes, the assertion was caused by the inconsistency between nsBidiPresUtils and nsTextFrameThebes.
Comment 6 User image Robert O'Callahan (:roc) (email my personal email if necessary) 2011-06-14 04:23:52 PDT
Comment on attachment 539148 [details] [diff] [review]

Review of attachment 539148 [details] [diff] [review]:
Comment 7 User image Simon Montagu :smontagu 2011-06-15 01:01:44 PDT
Comment 8 User image Daniel Veditz [:dveditz] 2011-08-11 17:10:08 PDT
Since we never shipped a release with this bug we don't need to keep it hidden.
Comment 9 User image Virgil Dicu [:virgil] [QA] 2011-08-19 06:50:57 PDT
Mozilla/5.0 (X11; Linux x86_64; rv:7.0) Gecko/20100101 Firefox/7.0

Could you provide some clear steps to reproduce in order to verify this issue on QA side?
Comment 10 User image Jesse Ruderman 2011-08-19 18:13:57 PDT
Virgil - just load the testcase in a build with assertions enabled (i.e. a debug build).
Comment 11 User image Anthony Hughes (:ashughes) [GFX][QA][Mentor] 2011-09-22 15:09:48 PDT
qa- as no QA fix verification needed

Note You need to log in before you can comment on or make changes to this bug.