Remove load-event-listening code from DOMParser

RESOLVED FIXED

Status

()

Core
DOM
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: sicking, Assigned: sicking)

Tracking

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 538817 [details] [diff] [review]
Patch to fix

The DOMParser code currently spins the event loop while waiting for the "load" event to fire on the newly parsed document. However spinning the event loop is evil and there doesn't seem to be a need to do so here.

It appears this code was added in bug 78622 due to xml-stylesheets blocking the parser. However those should no longer be enabled for DOMParser created docs, so I don't think it's needed any more.
Attachment #538817 - Flags: review?(Olli.Pettay)

Updated

6 years ago
Assignee: nobody → jonas

Comment 1

6 years ago
Comment on attachment 538817 [details] [diff] [review]
Patch to fix

(In reply to comment #0)
> those should no longer be enabled for DOMParser created
> docs, so I don't think it's needed any more.
When was XSLT on DOMParser documents disabled?

So it seems that nsIDOMParser expects that everything can be read from the stream
synchronously.
Attachment #538817 - Flags: review?(Olli.Pettay) → review+
Bug 172372 added this line back in 2002:

http://hg.mozilla.org/mozilla-central/annotate/b6f3d37f6fdb/content/xml/document/src/nsXMLContentSink.cpp#l723
Checked in. Thanks for the quick review

http://hg.mozilla.org/mozilla-central/rev/fafe864d8d8e
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.