Closed Bug 663752 Opened 12 years ago Closed 12 years ago

Remove load-event-listening code from DOMParser

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: sicking, Assigned: sicking)

References

Details

Attachments

(1 file)

Patch to fix
6.41 KB, patch
smaug
: review+
Details | Diff | Splinter Review
Attached patch Patch to fix — — Splinter Review 
The DOMParser code currently spins the event loop while waiting for the "load" event to fire on the newly parsed document. However spinning the event loop is evil and there doesn't seem to be a need to do so here.

It appears this code was added in bug 78622 due to xml-stylesheets blocking the parser. However those should no longer be enabled for DOMParser created docs, so I don't think it's needed any more.
Attachment #538817 - Flags: review?(Olli.Pettay)
Assignee: nobody → jonas
Comment on attachment 538817 [details] [diff] [review]
Patch to fix

(In reply to comment #0)
> those should no longer be enabled for DOMParser created
> docs, so I don't think it's needed any more.
When was XSLT on DOMParser documents disabled?

So it seems that nsIDOMParser expects that everything can be read from the stream
synchronously.
Attachment #538817 - Flags: review?(Olli.Pettay) → review+
Checked in. Thanks for the quick review

http://hg.mozilla.org/mozilla-central/rev/fafe864d8d8e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.