HistoryMenu.toggleTabsFromOtherComputers doesn't account for other uses of the HistoryMenu class

RESOLVED FIXED in Firefox 7

Status

()

Firefox
Menus
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: darktrojan, Assigned: darktrojan)

Tracking

Trunk
Firefox 7
Points:
---
Bug Flags:
in-testsuite ?

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

6 years ago
Created attachment 538838 [details] [diff] [review]
patch

The function toggles the 'tabs from other computers' item on the main history menu, regardless of which menu is displayed. The app button history menu uses the same class (although it doesn't have the menu item in question), and I know of at least one addon that uses it (because I wrote it).
Attachment #538838 - Flags: review?(mak77)
(In reply to comment #0)
> The app button history
> menu uses the same class (although it doesn't have the menu item in
> question),

What class does it use?
(Assignee)

Comment 2

6 years ago
HistoryMenu (by class I mean in Javascript not CSS, why do these things have to have the same name?)
Well, to be precise, JS doesn't have classes. ;-)
Comment on attachment 538838 [details] [diff] [review]
patch

Review of attachment 538838 [details] [diff] [review]:
-----------------------------------------------------------------

nit: What about a small comment like (feel free to make it real english): "// In some of the menus handled by HistoryMenu this menuitem may not exist."
Attachment #538838 - Flags: review?(mak77) → review+
(Assignee)

Comment 5

6 years ago
Created attachment 540222 [details] [diff] [review]
patch for checkin
Attachment #538838 - Attachment is obsolete: true
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
http://hg.mozilla.org/integration/mozilla-inbound/rev/4c809dfcb658
Keywords: checkin-needed
Whiteboard: [inbound]
Merged:
http://hg.mozilla.org/mozilla-central/rev/4c809dfcb658
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → Firefox 7
You need to log in before you can comment on or make changes to this bug.