663771 - HistoryMenu.toggleTabsFromOtherComputers doesn't account for other uses of the HistoryMenu class

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[Geoff Lankow (:darktrojan)]

Attachment: patch

The function toggles the 'tabs from other computers' item on the main history menu, regardless of which menu is displayed. The app button history menu uses the same class (although it doesn't have the menu item in question), and I know of at least one addon that uses it (because I wrote it).

Comment 1

[Dão Gottwald [:dao]]

(In reply to comment #0)
> The app button history
> menu uses the same class (although it doesn't have the menu item in
> question),

What class does it use?

Comment 2

[Geoff Lankow (:darktrojan)]

HistoryMenu (by class I mean in Javascript not CSS, why do these things have to have the same name?)

Comment 3

[Dão Gottwald [:dao]]

Well, to be precise, JS doesn't have classes. ;-)

Comment 4

[Marco Bonardo [:mak]]

Comment on attachment 538838 [details] [diff] [review]
patch

Review of attachment 538838 [details] [diff] [review]:
-----------------------------------------------------------------

nit: What about a small comment like (feel free to make it real english): "// In some of the menus handled by HistoryMenu this menuitem may not exist."

Comment 5

[Geoff Lankow (:darktrojan)]

Attachment: patch for checkin

Comment 6

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/4c809dfcb658

Comment 7

[Mounir Lamouri (:mounir)]

Merged:
http://hg.mozilla.org/mozilla-central/rev/4c809dfcb658