Last Comment Bug 663784 - gfxWindowsPlatform.cpp doesn't compile without D2D
: gfxWindowsPlatform.cpp doesn't compile without D2D
Product: Core
Classification: Components
Component: Graphics (show other bugs)
: Trunk
: x86 Windows 7
-- normal (vote)
: mozilla7
Assigned To: Jacek Caban
: Milan Sreckovic [:milan]
Depends on:
Blocks: 663036
  Show dependency treegraph
Reported: 2011-06-13 04:57 PDT by Jacek Caban
Modified: 2011-06-18 09:38 PDT (History)
4 users (show)
mounir: in‑testsuite-
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix v1.0 (791 bytes, patch)
2011-06-13 04:57 PDT, Jacek Caban
masayuki: review+
Details | Diff | Splinter Review
Fix using statement (1.72 KB, patch)
2011-06-16 05:48 PDT, Jacek Caban
masayuki: review+
Details | Diff | Splinter Review

Description User image Jacek Caban 2011-06-13 04:57:16 PDT
Created attachment 538863 [details] [diff] [review]
fix v1.0
Comment 1 User image Masayuki Nakano [:masayuki] 2011-06-13 18:15:46 PDT
Comment on attachment 538863 [details] [diff] [review]
fix v1.0

Oh, thanks!
Comment 2 User image Jacek Caban 2011-06-15 03:27:48 PDT
Thanks for review, pushed to inbound:
Comment 3 User image Matt Brubeck (:mbrubeck) 2011-06-15 08:44:10 PDT
Comment 4 User image :Ms2ger (⌚ UTC+1/+2) 2011-06-15 09:41:52 PDT
We don't put using statements before includes.
Comment 5 User image Jacek Caban 2011-06-16 05:48:30 PDT
Created attachment 539773 [details] [diff] [review]
Fix using statement

Oh, right. The attached patch fixes using statement. Previous code also had includes after using statement, this patch fixes that as well. It also removes WINCE code.
Comment 6 User image Jacek Caban 2011-06-17 06:03:00 PDT
Pushed to inbound:
Comment 7 User image Mounir Lamouri (:mounir) 2011-06-18 09:38:35 PDT
Merged to m-c:

Note You need to log in before you can comment on or make changes to this bug.