The default bug view has changed. See this FAQ.

gfxWindowsPlatform.cpp doesn't compile without D2D

RESOLVED FIXED in mozilla7

Status

()

Core
Graphics
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: Jacek Caban, Assigned: Jacek Caban)

Tracking

Trunk
mozilla7
x86
Windows 7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 years ago
Created attachment 538863 [details] [diff] [review]
fix v1.0
Attachment #538863 - Flags: review?(masayuki)

Updated

6 years ago
Component: GFX: Color Management → Graphics
Comment on attachment 538863 [details] [diff] [review]
fix v1.0

Oh, thanks!
Attachment #538863 - Flags: review?(masayuki) → review+
QA Contact: color-management → thebes
(Assignee)

Comment 2

6 years ago
Thanks for review, pushed to inbound:

http://hg.mozilla.org/integration/mozilla-inbound/rev/e363e219a4b8
Whiteboard: [inbound]
http://hg.mozilla.org/mozilla-central/rev/e363e219a4b8
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
We don't put using statements before includes.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 5

6 years ago
Created attachment 539773 [details] [diff] [review]
Fix using statement

Oh, right. The attached patch fixes using statement. Previous code also had includes after using statement, this patch fixes that as well. It also removes WINCE code.
(Assignee)

Updated

6 years ago
Attachment #539773 - Flags: review?(masayuki)
Attachment #539773 - Flags: review?(masayuki) → review+
(Assignee)

Comment 6

6 years ago
Pushed to inbound:

http://hg.mozilla.org/integration/mozilla-inbound/rev/1fc165fdfa07
Whiteboard: [inbound]
Merged to m-c:
http://hg.mozilla.org/mozilla-central/rev/1fc165fdfa07
Status: REOPENED → RESOLVED
Last Resolved: 6 years ago6 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Whiteboard: [inbound]
You need to log in before you can comment on or make changes to this bug.