663829 - [Regression] Checkboxes are difficult to check on Gmail

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect, P2)

Description

[Aakash Desai [:aakashd]]

Build Id:
Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110612 Firefox/7.0a1 Fennec/7.0a1 ID:20110612040154

Mozilla/5.0 (Android; Linux armv7l; rv:6.0a2) Gecko/20110612 Firefox/6.0a2 Fennec/6.0a2 ID:20110613054928

Note: This was not seen on the 6/6 build of Aurora. So, the regression window is between 6/6 - 6/12 Aurora. I tried this on mail.mozilla.com/zimbra and all the checkboxes there checked fine.

Step to Reproduce:
1. Go to www.gmail.com and login
2. Try to click on a bunch of checkboxes

Actual Results:
Not all the checkboxes will be checked (I was only able to check half of them even though each one, when tapped on, highlighted blue for 1/2 a second.

Expected Results:
All the checkboxes should be checked.

Comment 1

[Aaron Train [:aaronmt]]

Seeing this too (06/13, HTC Nexus One), but not just Gmail, really anywhere with checkboxes: 

http://www.echoecho.com/htmlforms09.htm

Comment 2

[Aaron Train [:aaronmt]]

Still seeing this on 06/20, unable to toggle value changes in checkboxes by tapping them

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Ben - Take a look at this. I can repro using a nightly

Comment 4

[Benjamin Stover (:stechz)]

At first I thought this could be some displayport problem, but these checkboxes *can* be checked after a couple of pokes. This makes me think that maybe we are cancelling taps sometimes when we shouldn't be (I've had this happen to me clicking links too).

Looking into it.

Comment 5

[Benjamin Stover (:stechz)]

Surprisingly, things look to be OK from Fennec's perspective. Very interesting. Lots of WARNINGs exactly when the click does not fire.

Comment 6

[Benjamin Stover (:stechz)]

Attachment: Checkboxes are difficult to check on Gmail

I'm confused how this was working at all before, because I think Rects can't
take a JSON top/left/width/height structure. Additionally, it's sometimes
possible to tap on the border of the checkbox where we consider it fractionally
"in bounds." This subtlety is lost on mouse events that I presume only deal
with integer offsets.

This code works pretty well for me now. Fast taps on different checkboxes is a
pain, but that is a balancing game with double tap that we can leave to a
separate bug.

Comment 7

[Wesley Johnston (:wesj)]

Comment on attachment 541213 [details] [diff] [review]
Checkboxes are difficult to check on Gmail

Review of attachment 541213 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 8

[Benjamin Stover (:stechz)]

Pushed to inbound http://hg.mozilla.org/integration/mozilla-inbound/rev/daf896f89f39

Comment 9

[Marco Bonardo [:mak]]

http://hg.mozilla.org/mozilla-central/rev/daf896f89f39

Comment 10

[Anna (Waverley)]

VERIFIED FIXED on:

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:7.0a1) Gecko/20110627 Firefox/7.0a1 Fennec/7.0a1 

Mozilla /5.0 (Android;Linux armv7l;rv:6.0a2) Gecko/20110627 Firefox/6.0a2 Fennec/6.0a2 

Device: HTC Desire Z (Android 2.2)

Comment 11

[Matt Brubeck (:mbrubeck)]

Comment on attachment 541213 [details] [diff] [review]
Checkboxes are difficult to check on Gmail

Nominating for approval-mozilla-aurora.  Straightforward low-risk fix for a regression that was reported as affecting both Aurora and trunk.  The fix touches mobile front-end code only (zero desktop risk).

Comment 12

[Matt Brubeck (:mbrubeck)]

The main part of this bug is a regression from bug 658727 which has not landed in Aurora, so this problem should not be as bad in Aurora as it is in Nightly.  The other part fixed by this patch does not appear to be a regression from previous versions, so I'm not sure it's necessary to take it in Aurora.