warning in nsHTMLTableAccessible.cpp:325

RESOLVED FIXED in mozilla7

Status

()

Core
Disability Access APIs
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

unspecified
mozilla7
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 539134 [details] [diff] [review]
patch
Attachment #539134 - Flags: review?(surkov.alexander)

Comment 2

6 years ago
Trevor, please give a warning message, otherwise it may be hard to understand what you fix here.

Comment 3

6 years ago
Comment on attachment 539134 [details] [diff] [review]
patch

Review of attachment 539134 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/html/nsHTMLTableAccessible.cpp
@@ +321,1 @@
>  

I'd suggest to use enum (you should give it a name) instead PRInt32 and do
PRUint32 headerRole = aRowOrColumnHeaderCell == nsAccUtils::eRowHeaderCells ?
nsIAccessibleRole::ROLE_ROWHEADER : nsIAccessibleRole::ROLE_COLUMNHEADER;
Attachment #539134 - Flags: review?(surkov.alexander) → review+

Updated

6 years ago
Assignee: nobody → trev.saunders
(Assignee)

Comment 4

6 years ago
(In reply to comment #3)
> Comment on attachment 539134 [details] [diff] [review] [review]
> patch
> 
> Review of attachment 539134 [details] [diff] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/src/html/nsHTMLTableAccessible.cpp
> @@ +321,1 @@
> >  
> 
> I'd suggest to use enum (you should give it a name) instead PRInt32 and do
> PRUint32 headerRole = aRowOrColumnHeaderCell == nsAccUtils::eRowHeaderCells ?
> nsIAccessibleRole::ROLE_ROWHEADER : nsIAccessibleRole::ROLE_COLUMNHEADER;

yeah, that would be nice.  I was thinking about  changing the parameter to an enum  and returning  a pointer to the array instead of the out param in bug 648265.  How does that sound?

Comment 5

6 years ago
not sure how you treat "a pointer to the array" but array as return value vs out argument is fine with me.
(Assignee)

Comment 6

6 years ago
landed http://hg.mozilla.org/mozilla-central/rev/b06efa3e0073
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
(Assignee)

Updated

6 years ago
Target Milestone: --- → mozilla7
(Assignee)

Comment 7

6 years ago
landed http://hg.mozilla.org/mozilla-central/rev/06c3225b1656
You need to log in before you can comment on or make changes to this bug.