Last Comment Bug 664083 - warning in nsHTMLTableAccessible.cpp:325
: warning in nsHTMLTableAccessible.cpp:325
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Disability Access APIs (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla7
Assigned To: Trevor Saunders (:tbsaunde)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-13 23:41 PDT by Trevor Saunders (:tbsaunde)
Modified: 2011-06-26 07:53 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.81 KB, patch)
2011-06-13 23:43 PDT, Trevor Saunders (:tbsaunde)
surkov.alexander: review+
Details | Diff | Review

Description Trevor Saunders (:tbsaunde) 2011-06-13 23:41:13 PDT

    
Comment 1 Trevor Saunders (:tbsaunde) 2011-06-13 23:43:13 PDT
Created attachment 539134 [details] [diff] [review]
patch
Comment 2 alexander :surkov 2011-06-15 00:52:38 PDT
Trevor, please give a warning message, otherwise it may be hard to understand what you fix here.
Comment 3 alexander :surkov 2011-06-15 00:58:04 PDT
Comment on attachment 539134 [details] [diff] [review]
patch

Review of attachment 539134 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/html/nsHTMLTableAccessible.cpp
@@ +321,1 @@
>  

I'd suggest to use enum (you should give it a name) instead PRInt32 and do
PRUint32 headerRole = aRowOrColumnHeaderCell == nsAccUtils::eRowHeaderCells ?
nsIAccessibleRole::ROLE_ROWHEADER : nsIAccessibleRole::ROLE_COLUMNHEADER;
Comment 4 Trevor Saunders (:tbsaunde) 2011-06-20 15:06:23 PDT
(In reply to comment #3)
> Comment on attachment 539134 [details] [diff] [review] [review]
> patch
> 
> Review of attachment 539134 [details] [diff] [review] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/src/html/nsHTMLTableAccessible.cpp
> @@ +321,1 @@
> >  
> 
> I'd suggest to use enum (you should give it a name) instead PRInt32 and do
> PRUint32 headerRole = aRowOrColumnHeaderCell == nsAccUtils::eRowHeaderCells ?
> nsIAccessibleRole::ROLE_ROWHEADER : nsIAccessibleRole::ROLE_COLUMNHEADER;

yeah, that would be nice.  I was thinking about  changing the parameter to an enum  and returning  a pointer to the array instead of the out param in bug 648265.  How does that sound?
Comment 5 alexander :surkov 2011-06-20 22:22:08 PDT
not sure how you treat "a pointer to the array" but array as return value vs out argument is fine with me.
Comment 6 Trevor Saunders (:tbsaunde) 2011-06-26 07:51:42 PDT
landed http://hg.mozilla.org/mozilla-central/rev/b06efa3e0073
Comment 7 Trevor Saunders (:tbsaunde) 2011-06-26 07:53:54 PDT
landed http://hg.mozilla.org/mozilla-central/rev/06c3225b1656

Note You need to log in before you can comment on or make changes to this bug.