664140 - Split GCHeap::AddrToBlock into BaseAddr and InteriorAddr variants

Status: RESOLVED FIXED

(Tamarin Graveyard :: Garbage Collection (mmGC), defect, P3)

Description

[Felix S. Klock II [:pnkfelix, :fklock]]

GCHeap::AddrToBlock currently doesn't work on addresses beyond the first block in the object.  Tommy says most of its callers are passing in the base address for the object.

So lets tighten up its contract (by making its assertion check that the given address matches the base address) and add a new variant for the callers that are using the non-base address; that new variant should be generalized as described in Bug 663508, comment 1.

Comment 1

[Felix S. Klock II [:pnkfelix, :fklock]]

Attachment: split GCHeap::AddrToBlock into {Base,Interior}AddrToBlock

Tommy: obviously if you land Bug 664133 then I'll remove the GC.cpp portion of this patch.

If requested, I'll look into adding a selftest, but my current plan is just to rely on the selftest already planned for Bug 663508 (see attachment 538905 [details] [diff] [review] ) to exercise this functionality, rather than worry about making an individual unit-test for these two functions.

Comment 2

[Felix S. Klock II [:pnkfelix, :fklock]]

Pushed to Serrano.

  tamarin-redux-serrano
  changeset: 6320:6995cfb192ae
  user:	     Felix S Klock II <[e-mail]>
  summary:   Bug 664140: split GCHeap::AddrToBlock into BaseAddr and InteriorAddr variants. (r=treilly, sr pending lhansen).
  http://asteam.corp.adobe.com/hg/tamarin-redux-serrano/rev/6995cfb192ae

Comment 3

[Tamarin Bot]

changeset: 6407:1735c8e8ba1c
user:      Felix S Klock II <[e-mail]>
summary:   Bug 664140: split GCHeap::AddrToBlock into input-specific variants (r=treilly, sr=lhansen).

http://hg.mozilla.org/tamarin-redux/rev/1735c8e8ba1c