The default bug view has changed. See this FAQ.

move content/base/test/chrome/test_bug574596.html to mochitest-chrome

RESOLVED FIXED

Status

()

Core
Drag and Drop
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: jmaher, Assigned: jmaher)

Tracking

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [specialpowers])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

6 years ago
test_bug574596 uses drag and drop which requires enablePrivilege.  If we can move this to mochitest-chrome this will keep the specialpowers code simpler.
(Assignee)

Comment 1

6 years ago
Created attachment 539223 [details] [diff] [review]
move test_bug574596.html to mochitest-chrome (1.0)

:mats, can review this patch and verify that we will get the same coverage when run as mochitest chrome?
Assignee: nobody → jmaher
Attachment #539223 - Flags: review?(matspal)
Comment on attachment 539223 [details] [diff] [review]
move test_bug574596.html to mochitest-chrome (1.0)

This patch looks incomplete...
The file "chrome/test_bug574596.html" is missing.
Attachment #539223 - Flags: review?(matspal) → review-
(Assignee)

Comment 3

6 years ago
Created attachment 540082 [details] [diff] [review]
move test_bug574596.html to mochitest-chrome (1.1)

odd, for some reason that patch I uploaded was missing the bottom half after the hg rename.
Attachment #539223 - Attachment is obsolete: true
Attachment #540082 - Flags: review?(matspal)
Comment on attachment 540082 [details] [diff] [review]
move test_bug574596.html to mochitest-chrome (1.1)

> _CHROME_FILES = \
>+    test_bug574596.html \

Add it at the end of the list instead, to (somewhat) maintain
bug number order.

> content/base/test/chrome/test_bug574596.html

Why not remove the enablePrivilege() call?
Attachment #540082 - Flags: review?(matspal) → review+
(Assignee)

Comment 5

6 years ago
Created attachment 540311 [details] [diff] [review]
move test_bug574596.html to mochitest-chrome (1.2)

final patch with nits addressed
Attachment #540082 - Attachment is obsolete: true
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/mozilla-central/rev/058a584ea7d3
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.