Last Comment Bug 664158 - move content/base/test/chrome/test_bug574596.html to mochitest-chrome
: move content/base/test/chrome/test_bug574596.html to mochitest-chrome
Status: RESOLVED FIXED
[specialpowers]
:
Product: Core
Classification: Components
Component: Drag and Drop (show other bugs)
: Trunk
: x86 Linux
: -- normal (vote)
: ---
Assigned To: Joel Maher ( :jmaher)
:
: Neil Deakin
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-14 08:57 PDT by Joel Maher ( :jmaher)
Modified: 2011-06-19 17:25 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
move test_bug574596.html to mochitest-chrome (1.0) (1.61 KB, patch)
2011-06-14 08:59 PDT, Joel Maher ( :jmaher)
mats: review-
Details | Diff | Splinter Review
move test_bug574596.html to mochitest-chrome (1.1) (2.92 KB, patch)
2011-06-17 10:22 PDT, Joel Maher ( :jmaher)
mats: review+
Details | Diff | Splinter Review
move test_bug574596.html to mochitest-chrome (1.2) (3.73 KB, patch)
2011-06-19 03:41 PDT, Joel Maher ( :jmaher)
no flags Details | Diff | Splinter Review

Description Joel Maher ( :jmaher) 2011-06-14 08:57:23 PDT
test_bug574596 uses drag and drop which requires enablePrivilege.  If we can move this to mochitest-chrome this will keep the specialpowers code simpler.
Comment 1 Joel Maher ( :jmaher) 2011-06-14 08:59:00 PDT
Created attachment 539223 [details] [diff] [review]
move test_bug574596.html to mochitest-chrome (1.0)

:mats, can review this patch and verify that we will get the same coverage when run as mochitest chrome?
Comment 2 Mats Palmgren (:mats) 2011-06-16 12:47:54 PDT
Comment on attachment 539223 [details] [diff] [review]
move test_bug574596.html to mochitest-chrome (1.0)

This patch looks incomplete...
The file "chrome/test_bug574596.html" is missing.
Comment 3 Joel Maher ( :jmaher) 2011-06-17 10:22:08 PDT
Created attachment 540082 [details] [diff] [review]
move test_bug574596.html to mochitest-chrome (1.1)

odd, for some reason that patch I uploaded was missing the bottom half after the hg rename.
Comment 4 Mats Palmgren (:mats) 2011-06-17 13:10:10 PDT
Comment on attachment 540082 [details] [diff] [review]
move test_bug574596.html to mochitest-chrome (1.1)

> _CHROME_FILES = \
>+    test_bug574596.html \

Add it at the end of the list instead, to (somewhat) maintain
bug number order.

> content/base/test/chrome/test_bug574596.html

Why not remove the enablePrivilege() call?
Comment 5 Joel Maher ( :jmaher) 2011-06-19 03:41:12 PDT
Created attachment 540311 [details] [diff] [review]
move test_bug574596.html to mochitest-chrome (1.2)

final patch with nits addressed
Comment 6 Joel Maher ( :jmaher) 2011-06-19 17:25:05 PDT
http://hg.mozilla.org/mozilla-central/rev/058a584ea7d3

Note You need to log in before you can comment on or make changes to this bug.