Closed
Bug 664158
Opened 14 years ago
Closed 14 years ago
move content/base/test/chrome/test_bug574596.html to mochitest-chrome
Categories
(Core :: DOM: Copy & Paste and Drag & Drop, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: jmaher, Assigned: jmaher)
Details
(Whiteboard: [specialpowers])
Attachments
(1 file, 2 obsolete files)
|
3.73 KB,
patch
|
Details | Diff | Splinter Review |
test_bug574596 uses drag and drop which requires enablePrivilege. If we can move this to mochitest-chrome this will keep the specialpowers code simpler.
|
Assignee | |
Comment 1•14 years ago
|
||
:mats, can review this patch and verify that we will get the same coverage when run as mochitest chrome?
Assignee: nobody → jmaher
Attachment #539223 -
Flags: review?(matspal)
|
||
Comment 2•14 years ago
|
||
Comment on attachment 539223 [details] [diff] [review]
move test_bug574596.html to mochitest-chrome (1.0)
This patch looks incomplete...
The file "chrome/test_bug574596.html" is missing.
Attachment #539223 -
Flags: review?(matspal) → review-
|
|
Assignee | |
Comment 3•14 years ago
|
||
odd, for some reason that patch I uploaded was missing the bottom half after the hg rename.
Attachment #539223 -
Attachment is obsolete: true
Attachment #540082 -
Flags: review?(matspal)
|
|
||
Comment 4•14 years ago
|
||
Comment on attachment 540082 [details] [diff] [review]
move test_bug574596.html to mochitest-chrome (1.1)
> _CHROME_FILES = \
>+ test_bug574596.html \
Add it at the end of the list instead, to (somewhat) maintain
bug number order.
> content/base/test/chrome/test_bug574596.html
Why not remove the enablePrivilege() call?
Attachment #540082 -
Flags: review?(matspal) → review+
|
|
Assignee | |
Comment 5•14 years ago
|
||
final patch with nits addressed
Attachment #540082 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•14 years ago
|
||
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•