Closed Bug 664235 Opened 9 years ago Closed 9 years ago

graph colors don't match milestone color

Categories

(Socorro :: General, task)

x86
All
task
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: jbecerra, Assigned: lonnen)

References

()

Details

Attachments

(2 files, 2 obsolete files)

One of the lines in the graph of crashes per adu doesn't match the column color in the milestones. See 6.0a2 which is yellow, but there's now yellow in the graph.

http://grab.by/am1F

Steps:
1. Go to crash-stats
2. Choose crashes per adu from the report drop-down

Expected: All milestones are represented by a graph matching its color in the column

Actual: One of them milestone colors doesn't match.
Assignee: nobody → chris.lonnen
Attached file Unifies how graph colors are handled (obsolete) —
This patch removes the dashboard.js special case and modifies daily.js to properly color whatever corresponding legend appears.

Use `patch -p1 < path/to/b664235v2.patch` to apply.
Attachment #542659 - Flags: review?(adrian)
Attachment #542659 - Attachment is patch: true
Attachment #542659 - Attachment mime type: text/x-patch → text/plain
Comment on attachment 542659 [details]
Unifies how graph colors are handled

In daily.css, version1, version2 and so on are not used anymore. You should remove it.
Attachment #542659 - Attachment is patch: false
Attachment #542659 - Attachment mime type: text/plain → text/x-patch
Attachment #542659 - Flags: review?(adrian) → review-
Pruned the dead css.

This one should be a normal `patch -p0`
Attachment #542659 - Attachment is obsolete: true
Attachment #542685 - Flags: review?(adrian)
Attachment #542685 - Flags: review?(adrian) → review+
checked into trunk as r3253
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Cool, thanks! When can we expect this to appear in production?
Target Milestone: --- → 2.1
The copy of /js/socorro/daily.js is different than what is in both trunk and the release branch 

Compare:
https://crash-stats.allizom.org/js/socorro/daily.js

http://code.google.com/p/socorro/source/browse/branches/releases/2.1/webapp-php/js/socorro/daily.js

Significantly, its missing the function that aligns the colors. 

Also, judging from the out output, the php that generates that page is out of date. It is still generating class="version{someNumber}" tags. The check in that fixes this trimmed those to be class="version".
As there isn't much data at all on crash-stats-dev, I'll wait until this fix lands on staging, then :-)
Component: Socorro → General
Product: Webtools → Socorro
You need to log in before you can comment on or make changes to this bug.