664235 - graph colors don't match milestone color

Status: VERIFIED FIXED

(Socorro :: General, task)

Description

[juan becerra [:juanb]]

One of the lines in the graph of crashes per adu doesn't match the column color in the milestones. See 6.0a2 which is yellow, but there's now yellow in the graph.

http://grab.by/am1F

Steps:
1. Go to crash-stats
2. Choose crashes per adu from the report drop-down

Expected: All milestones are represented by a graph matching its color in the column

Actual: One of them milestone colors doesn't match.

Comment 1

[Lonnen :lonnen]

Attachment: Unifies how graph colors are handled

This patch removes the dashboard.js special case and modifies daily.js to properly color whatever corresponding legend appears.

Use `patch -p1 < path/to/b664235v2.patch` to apply.

Comment 2

[[DEACTIVATED] Adrian Gaudebert]

Comment on attachment 542659 [details]
Unifies how graph colors are handled

In daily.css, version1, version2 and so on are not used anymore. You should remove it.

Comment 3

[Lonnen :lonnen]

Attachment: Unifies how colors and handled, prunes out dead CSS

Pruned the dead css.

This one should be a normal `patch -p0`

Comment 4

[Lonnen :lonnen]

checked into trunk as r3253

Comment 5

[Robert Kaiser]

Cool, thanks! When can we expect this to appear in production?

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Juan, mind playing around with this on https://crash-stats.allizom.org, too?

I looked at https://crash-stats.allizom.org/daily?form_selection=by_version&p=Firefox&v%5B%5D=5.0&throttle%5B%5D=10.00&v%5B%5D=3.5.13&throttle%5B%5D=10.00&v%5B%5D=3.6&throttle%5B%5D=10.00&v%5B%5D=3.6.3&throttle%5B%5D=10.00&hang_type=any&os%5B%5D=Windows&os%5B%5D=Mac&os%5B%5D=Linux&date_start=2011-07-10&date_end=2011-07-24&submit=Generate

Comment 8

[Lonnen :lonnen]

The copy of /js/socorro/daily.js is different than what is in both trunk and the release branch 

Compare:
https://crash-stats.allizom.org/js/socorro/daily.js

http://code.google.com/p/socorro/source/browse/branches/releases/2.1/webapp-php/js/socorro/daily.js

Significantly, its missing the function that aligns the colors. 

Also, judging from the out output, the php that generates that page is out of date. It is still generating class="version{someNumber}" tags. The check in that fixes this trimmed those to be class="version".

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

As there isn't much data at all on crash-stats-dev, I'll wait until this fix lands on staging, then :-)

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

Attachment: Post-fix screenshot

Comment 11

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using https://crash-stats.allizom.org/daily?form_selection=by_version&p=Firefox&v%5B%5D=6.0&throttle%5B%5D=100.00&v%5B%5D=7.0a1&throttle%5B%5D=100.00&v%5B%5D=5.0&throttle%5B%5D=100&v%5B%5D=5.0.1&throttle%5B%5D=10.00&hang_type=any&os%5B%5D=Windows&os%5B%5D=Mac&os%5B%5D=Linux&date_start=2011-07-10&date_end=2011-07-24&submit=Generate.