Last Comment Bug 664354 - nsBuiltinDecoderStateMachine::GetUndecodedData() returns result in milliseconds not microseconds
: nsBuiltinDecoderStateMachine::GetUndecodedData() returns result in millisecon...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Audio/Video (show other bugs)
: Trunk
: All All
: -- normal (vote)
: ---
Assigned To: Chris Pearce (:cpearce)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-14 19:16 PDT by Chris Pearce (:cpearce)
Modified: 2011-06-14 19:49 PDT (History)
0 users
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (959 bytes, patch)
2011-06-14 19:18 PDT, Chris Pearce (:cpearce)
roc: review+
Details | Diff | Splinter Review

Description Chris Pearce (:cpearce) 2011-06-14 19:16:58 PDT
nsBuiltinDecoderStateMachine::GetUndecodedData() is supposed to return the number of microseconds of undecoded data, but it's returning the number of seconds of undecoded data. My bad.
Comment 1 Chris Pearce (:cpearce) 2011-06-14 19:18:51 PDT
Created attachment 539400 [details] [diff] [review]
Patch
Comment 2 Robert O'Callahan (:roc) (email my personal email if necessary) 2011-06-14 19:21:07 PDT
Comment on attachment 539400 [details] [diff] [review]
Patch

Review of attachment 539400 [details] [diff] [review]:
-----------------------------------------------------------------
Comment 3 Chris Pearce (:cpearce) 2011-06-14 19:31:11 PDT
(In reply to comment #0)
> nsBuiltinDecoderStateMachine::GetUndecodedData() is supposed to return the
> number of microseconds of undecoded data, but it's returning the number of
> seconds of undecoded data. My bad.

I meant it's returning a result in milliseconds not seconds.
Comment 4 Chris Pearce (:cpearce) 2011-06-14 19:49:51 PDT
http://hg.mozilla.org/mozilla-central/rev/2185b561e5e1

Note You need to log in before you can comment on or make changes to this bug.