66443 - NSS build instructions on Mozilla do not work

Status: RESOLVED INVALID

(SeaMonkey :: Build Config, defect, P4)

Description

[Jamie Nicolson]

My builds on AIX are failing miserably because configure is picking a bogus 
version of perl. I can workaround for now.

There's some code in mozilla/configure that tests Perl to make sure it's at 
least version 5.004. The code looks like this:

use Config;
print "$Config{version}";
if ($Config{version} >= $PERL_VERSION) { exit(0); }
else { exit(1); }

/tools/ns/bin/perl5 just happens to be in my path on my AIX machine, but its 
version of the Config module does not define a variable named "version". Hence 
this code doesn't work. This version of Config.pm is from Perl 5.003 and is 
located at:
/tools/ns/soft/perl-5.003/run/default/rs6000_ibm_aix4.1/lib/perl5/aix/5.003/Conf
ig.pm

On the other hand, the variable $] seems to display the version number correctly 
in both 5.003 and 5.005. Couldn't we use this instead of $Config{version}?

Comment 1

[cls]

Attachment: Use $] for version number. Add separate check for Config.pm

Comment 2

[cls]

Patch has been checked in.  Marking fixed.

Comment 3

[cls]

*** Bug 71352 has been marked as a duplicate of this bug. ***

Comment 4

[cls]

Reopening.

Comment 5

[cls]

Attachment: Need to set PERL_VERSION in env so the test script can find it

Comment 6

[cls]

Patch has been checked in.  Marking fixed again.  Sonmi, can you verify this?

Comment 7

[Sonja Mirtitsch]

Well, the configure script has new output now, but it still finishes running,
and the error shows up in the following gmake. To me this is still not
acceptable behavior, so I am reopening.
I will attach a log so you can see the output for yourself.

Comment 8

[Sonja Mirtitsch]

Attachment: config.log

Comment 9

[Sonja Mirtitsch]

Attachment: log captured with > (different)

Comment 10

[Sonja Mirtitsch]

Attachment: gmake error and perl -v

Comment 11

[cls]

Strange.  I made that test on hotaix.mcom.com and just tested it again.  What
version of configure & configure.in do you have?
 
checking for perl5... /tools/ns/bin/perl5
checking for minimum required perl version >= 5.004... 5.003
configure: error: Perl 5.004 or higher is required.
hotaix /builds/cltbld/obj % 

Comment 12

[cls]

--->8 *snip* 8<---
Date: Fri, 09 Mar 2001 19:11:31 -0800
From: [e-mail] (Sonja Mirtitsch)
  To: [e-mail]

Hi,

bugzilla is down...

I use whatever is pulled by

cvs co -r NSS_3_2_RTM mozilla/client.mk
cd mozilla
gmake -f client.mk pull_all BUILD_MODULES=dbm MOZ_CO_TAG=NSS_3_2_RTM
NSPR_CO_TAG=NSPRPUB_RELEASE_4_1

--->8 *snip* 8<---

Since sonmi is pulling by a tag, he's not seeing the updates on the trunk. 
Marking fixed again.  Some please verify with a trunk build.

Comment 13

[Sonja Mirtitsch]

This can't be marked as fixed as long as our build instructions on the web are
broken.
This needs to be fixed in the branch as well

Comment 14

[Sonja Mirtitsch]

Adding Bob Lord and Bob Relyea, since one symptom of this bug is, that nobody
inside the iPlanet Network can build NSS with our published instructions on AIX
and HP, and the source of the problem is very hard to find without the fix in
the NSS_3_2 branch of configure.

Comment 15

[cls]

That's a separate issue completely.  The configure test has been fixed and the
fix has been checked in.  Marking the bug as such.  The test is supposed to
inform you when you don't have the proper version of perl.  That is merely an
informative message.  The bottom line is that you are still required to have the
proper version of perl.  The presence or absence of this test is not going to
change that.  Nor are updated build instructions (unless they are explicitly
telling you to use the older version of perl).

NSS has been tagged and released.  I do believe that is a tag not a branch.  You
cannot retroactively add a tweak to a released tag.  

Comment 16

[Sonja Mirtitsch]

We have a broken build, and it breaks on some gmake command with an obscure
errormessage. The configure script identifies a problem, but does not exit with
an error.

I think management should decide what to do with this bug, but closing it is not
the right solution.

I paste in the rest of the email after the

--->8 *snip* 8<---


I did not know that we had tagged the configure script as well.

Sorry, but NSS 3.2 has been released, and my job is to make sure the build
instructions we published on the web work.
Either we have to find an easy way to pull a certain dbm and a certain nspr, and
update the build instructions, or the tagged configure script has to be fixed as
well.

I can not make the decision what to do, so I am CC'ing Bob Relyea, who is the
NSS manager while Wan Teh is on sabbatical.

Sonja

Comment 17

[Sonja Mirtitsch]

this issue needs a decision.

Comment 18

[Sonja Mirtitsch]

changing the QA contact

Comment 19

[Robert Relyea]

There are two issues being discussed here.
	1) a problem with the config script.
	2) NSS does not build according to the instructions.

Reading the comments it looks like #1 is fixed, but #2 is not for two reasons:
	1) our internal tools environment is broken (old versions of perl are continually
being placed in /ns/tools/bin -- this requires release engineering to fix.
	2) Chris's fix to the config script is not tagged NSS_3_2 so the build
instructions are wrong.

Because of this I'm changing the summary of this bug to reflect the current
issue, I've included Sean on the CC list, and propose a fix:

Nelson has checked in the Makefiles to build dbm without importing the entire
mozilla build system. That means we can publish instructions that 1) are
simpler, 2) do not depend on perl at all, and 3) work. We are testing a
prototype version of these instructions now. They will probably mean advancing
the NSS_3_2 tag on mozilla/security/nss/Makefile.

bob

Comment 20

[Jon Granrose]

SPAM: mozilla 0.9 (and M1, and 0.8.1, etc.) has left the building.  please
update the target milestone so we can get a good idea of what's left for 0.9.1.

Comment 21

[Jamie Nicolson]

NSS doesn't use the Mozilla configure script anymore, right? Does PSM?

I'm going to mark this bug as invalid, since NSS builds independently of 
mozilla now.