664430 - Make sure PopupManager doesn't keep objects alive after xpcom-shutdown

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

This is not about fixing any real runtime leak, but only to make sure the
objects aren't kept alive on shutdown.

Comment 1

[Neil Deakin]

There's bug 480191 which suggests more of a cycle collector thing.

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

Nothing there suggest a cycle collector thing. Peter just says that something
should break the cycle, and the patch in this bug does that.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

But I'll verify if I can reproduce the leak with the patch.

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

At least with the patch I can't reproduce the leak.

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

And actually, since popupmanager is a singleton which will stay alive
until shutdown, adding traverse/unlink is effectively the same as
releasing member during xpcom-shutdown.

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

http://hg.mozilla.org/mozilla-central/rev/cbd6b39597c6