Closed Bug 664430 Opened 9 years ago Closed 9 years ago

Make sure PopupManager doesn't keep objects alive after xpcom-shutdown

Categories

(Core :: XUL, defect)

x86_64
Linux
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(1 file)

Attached patch patchSplinter Review
This is not about fixing any real runtime leak, but only to make sure the
objects aren't kept alive on shutdown.
Attachment #539520 - Flags: review?(enndeakin)
There's bug 480191 which suggests more of a cycle collector thing.
Assignee: nobody → Olli.Pettay
Nothing there suggest a cycle collector thing. Peter just says that something
should break the cycle, and the patch in this bug does that.
But I'll verify if I can reproduce the leak with the patch.
At least with the patch I can't reproduce the leak.
And actually, since popupmanager is a singleton which will stay alive
until shutdown, adding traverse/unlink is effectively the same as
releasing member during xpcom-shutdown.
Attachment #539520 - Flags: review?(enndeakin) → review+
http://hg.mozilla.org/mozilla-central/rev/cbd6b39597c6
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Blocks: 480191
You need to log in before you can comment on or make changes to this bug.