Make sure PopupManager doesn't keep objects alive after xpcom-shutdown

RESOLVED FIXED

Status

()

Core
XUL
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 539520 [details] [diff] [review]
patch

This is not about fixing any real runtime leak, but only to make sure the
objects aren't kept alive on shutdown.
Attachment #539520 - Flags: review?(enndeakin)

Comment 1

6 years ago
There's bug 480191 which suggests more of a cycle collector thing.
(Assignee)

Updated

6 years ago
Assignee: nobody → Olli.Pettay
(Assignee)

Comment 2

6 years ago
Nothing there suggest a cycle collector thing. Peter just says that something
should break the cycle, and the patch in this bug does that.
(Assignee)

Comment 3

6 years ago
But I'll verify if I can reproduce the leak with the patch.
(Assignee)

Comment 4

6 years ago
At least with the patch I can't reproduce the leak.
(Assignee)

Comment 5

6 years ago
And actually, since popupmanager is a singleton which will stay alive
until shutdown, adding traverse/unlink is effectively the same as
releasing member during xpcom-shutdown.

Updated

6 years ago
Attachment #539520 - Flags: review?(enndeakin) → review+
(Assignee)

Comment 6

6 years ago
http://hg.mozilla.org/mozilla-central/rev/cbd6b39597c6
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Blocks: 480191
You need to log in before you can comment on or make changes to this bug.