Closed Bug 664455 Opened 13 years ago Closed 13 years ago

Traverse/Unlink contentsink some more

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(1 file)

patch
1.32 KB, patch
hsivonen
: review+
Details | Diff | Splinter Review
Attached patch patch — — Splinter Review 
I don't have a testcase for possible leak, but while going through some 
other code, this looked a bit suspicious.
Attachment #539553 - Flags: review?(hsivonen)
Comment on attachment 539553 [details] [diff] [review]
patch

r=me provided that you have another in-flight patch that makes nsScriptLoader a CC participant.

(Aside: It's very sad that this stuff touches the content sink in the first place. I want to get rid of mScriptElements and move the parser blocking logic entirely to the script loader, but so many other things to do...)
Attachment #539553 - Flags: review?(hsivonen) → review+
uh, I don't have such. Good that you noticed, since scriptloader sure should be
CC-able.
http://hg.mozilla.org/mozilla-central/rev/bd8214b3bcaf

I'll fix the followup bug soon.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.