Last Comment Bug 664463 - Don't load anything to frameloader if it isn't in the docshell tree anymore
: Don't load anything to frameloader if it isn't in the docshell tree anymore
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: DOM (show other bugs)
: unspecified
: x86_64 Linux
: -- normal with 1 vote (vote)
: ---
Assigned To: Olli Pettay [:smaug] (high review load, please consider other reviewers)
:
Mentors:
Depends on:
Blocks: strongparent
  Show dependency treegraph
 
Reported: 2011-06-15 09:19 PDT by Olli Pettay [:smaug] (high review load, please consider other reviewers)
Modified: 2011-06-15 13:36 PDT (History)
4 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.52 KB, patch)
2011-06-15 09:19 PDT, Olli Pettay [:smaug] (high review load, please consider other reviewers)
no flags Details | Diff | Review
fixed (1.53 KB, patch)
2011-06-15 12:17 PDT, Olli Pettay [:smaug] (high review load, please consider other reviewers)
bzbarsky: review+
Details | Diff | Review

Description Olli Pettay [:smaug] (high review load, please consider other reviewers) 2011-06-15 09:19:11 PDT
Created attachment 539557 [details] [diff] [review]
patch

This is similar to Bug 610571.
Unfortunately I don't have a testcase for this, but this was in my
strong-parent-node patch.

r- if you think I should find some über-strange testcase for this.
Comment 1 :Ms2ger 2011-06-15 11:00:27 PDT
Comment on attachment 539557 [details] [diff] [review]
patch

>--- a/content/base/src/nsFrameLoader.cpp
>+++ b/content/base/src/nsFrameLoader.cpp
>   nsCOMPtr<nsISupports> container =
>     doc->GetContainer();
>   nsCOMPtr<nsIWebNavigation> parentAsWebNav = do_QueryInterface(container);
>+  NS_ENSURE_STATE(container);

Wouldn't you want to check parentAsWebNav here?
Comment 2 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2011-06-15 12:17:53 PDT
Created attachment 539613 [details] [diff] [review]
fixed
Comment 3 Boris Zbarsky [:bz] (Out June 25-July 6) 2011-06-15 12:57:06 PDT
Comment on attachment 539613 [details] [diff] [review]
fixed

Yeah, I think this is ok.
Comment 4 Olli Pettay [:smaug] (high review load, please consider other reviewers) 2011-06-15 13:36:42 PDT
http://hg.mozilla.org/mozilla-central/rev/cab0115bbc48

Note You need to log in before you can comment on or make changes to this bug.