Closed Bug 664463 Opened 8 years ago Closed 8 years ago
Don't load anything to frameloader if it isn't in the docshell tree anymore
This is similar to Bug 610571. Unfortunately I don't have a testcase for this, but this was in my strong-parent-node patch. r- if you think I should find some über-strange testcase for this.
Comment on attachment 539557 [details] [diff] [review] patch >--- a/content/base/src/nsFrameLoader.cpp >+++ b/content/base/src/nsFrameLoader.cpp > nsCOMPtr<nsISupports> container = > doc->GetContainer(); > nsCOMPtr<nsIWebNavigation> parentAsWebNav = do_QueryInterface(container); >+ NS_ENSURE_STATE(container); Wouldn't you want to check parentAsWebNav here?
Comment on attachment 539613 [details] [diff] [review] fixed Yeah, I think this is ok.
Attachment #539613 - Flags: review?(bzbarsky) → review+
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.